Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: content/common/gpu/media/v4l2_device.h

Issue 1822983002: Support external buffer import in VDA interface and add a V4L2SVDA impl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/v4l2_device.h
diff --git a/content/common/gpu/media/v4l2_device.h b/content/common/gpu/media/v4l2_device.h
index d66413c43a3631184862198427bf4cf8b7e4c316..a79b84fb07cdb8262a529ae31b36a2f6e965067e 100644
--- a/content/common/gpu/media/v4l2_device.h
+++ b/content/common/gpu/media/v4l2_device.h
@@ -12,6 +12,9 @@
#include <stddef.h>
#include <stdint.h>
+#include <linux/videodev2.h>
+
+#include "base/files/scoped_file.h"
#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
#include "media/base/video_decoder_config.h"
@@ -86,22 +89,31 @@ class CONTENT_EXPORT V4L2Device
// Returns true on success.
virtual bool Initialize() = 0;
+ // Return a vector of dmabuf file descriptors, exported for V4L2 buffer with
+ // |index|, assuming the buffer contains |num_planes| V4L2 planes and is of
+ // |type|. Return an empty vector on failure.
+ // The caller is responsible for closing the file descriptors after use.
+ virtual std::vector<base::ScopedFD> GetDmabufsForV4L2Buffer(
+ int index,
+ size_t num_planes,
+ enum v4l2_buf_type type) = 0;
+
// Return true if the given V4L2 pixfmt can be used in CreateEGLImage()
// for the current platform.
virtual bool CanCreateEGLImageFrom(uint32_t v4l2_pixfmt) = 0;
- // Creates an EGLImageKHR since each V4L2Device may use a different method of
- // acquiring one and associating it to the given texture. The texture_id is
- // used to bind the texture to the returned EGLImageKHR. buffer_index can be
- // used to associate the returned EGLImageKHR by the underlying V4L2Device
- // implementation.
- virtual EGLImageKHR CreateEGLImage(EGLDisplay egl_display,
- EGLContext egl_context,
- GLuint texture_id,
- gfx::Size frame_buffer_size,
- unsigned int buffer_index,
- uint32_t v4l2_pixfmt,
- size_t num_v4l2_planes) = 0;
+ // Create an EGLImage from provided |dmabuf_fds| and bind |texture_id| to it.
+ // Some implementations may also require the V4L2 |buffer_index| of the buffer
+ // for which |dmabuf_fds| have been exported.
kcwu 2016/03/22 07:47:01 Do we need to keep |dmabuf_fds| open after CreateE
Owen Lin 2016/03/23 06:32:49 How about using std::vector<base::ScopedFD> as the
Pawel Osciak 2016/03/28 01:31:28 I intended to keep the option of retaining referen
Pawel Osciak 2016/03/28 01:31:28 No. Adding to the doc.
+ // Return EGL_NO_IMAGE_KHR on failure.
+ virtual EGLImageKHR CreateEGLImage(
+ EGLDisplay egl_display,
+ EGLContext /* egl_context */,
kcwu 2016/03/22 07:47:02 remove /* */
Pawel Osciak 2016/03/28 01:31:28 Done.
+ GLuint texture_id,
+ const gfx::Size& size,
+ unsigned int buffer_index,
+ uint32_t v4l2_pixfmt,
+ const std::vector<base::ScopedFD>& dmabuf_fds) = 0;
// Destroys the EGLImageKHR.
virtual EGLBoolean DestroyEGLImage(EGLDisplay egl_display,

Powered by Google App Engine
This is Rietveld 408576698