InstantExtended: Remove overlay control code.

InstantExtended: Remove overlay control code.

This change deletes the browser-side InstantController code pertaining
to old Instant, the HTML popup and search results overlay. A lot of UI
and renderer code is still lingering and doing nothing, but I'll get
that in another CL.

TEST=Manually. Verify that InstantExtended NTP and searching works, and
that normal Chrome is unaffected.
BUG=251262
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210036

[Jered, 2013-06-28 18:11:55]

Please review this giant CL.
samarth -> instant, *
brettw -> browser miscellany outside instant
pkasting -> omnibox

[Peter Kasting, 2013-06-28 18:47:54]

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_controller.cc (right):

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_controller.cc:138: return false;
Should there be a TODO to nuke this function too?

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:1180: #if
defined(HTML_INSTANT_EXTENDED_POPUP)
Should this be nuked?

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.h (right):

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:301: void
OnCurrentMatchChanged(bool is_temporary_set_by_instant);
This function is now never called with its arg set to |true|.  Should that arg,
and |is_temporary_text_set_by_instant_|, be nuked?

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:304: void OnGrayTextChanged();
This function now has no callers, should it be deleted?

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:498: size_t
selected_instant_autocomplete_match_index_;
AFAICT, this variable and the next are never true.  These should probably be
nuked.

[Jered, 2013-06-28 19:09:55]

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_controller.cc (right):

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_controller.cc:138: return false;
On 2013/06/28 18:47:55, Peter Kasting wrote:
> Should there be a TODO to nuke this function too?

Just did it.

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:1180: #if
defined(HTML_INSTANT_EXTENDED_POPUP)
On 2013/06/28 18:47:55, Peter Kasting wrote:
> Should this be nuked?

Done.

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.h (right):

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:301: void
OnCurrentMatchChanged(bool is_temporary_set_by_instant);
On 2013/06/28 18:47:55, Peter Kasting wrote:
> This function is now never called with its arg set to |true|.  Should that
arg,
> and |is_temporary_text_set_by_instant_|, be nuked?

Done.

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:304: void OnGrayTextChanged();
On 2013/06/28 18:47:55, Peter Kasting wrote:
> This function now has no callers, should it be deleted?

Done.

https://codereview.chromium.org/18223002/diff/2003/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:498: size_t
selected_instant_autocomplete_match_index_;
On 2013/06/28 18:47:55, Peter Kasting wrote:
> AFAICT, this variable and the next are never true.  These should probably be
> nuked.

Done.

[Peter Kasting, 2013-06-28 20:50:54]

I don't know how many pieces you want to try and pull out now.  Here are some
more bits that are or may be dead:

OmniboxController: gray_suggestion_, gray_suggestion(), SetInstantSuggestion()

OmniboxEditModel: CommitSuggestedText(), GetInstantController(), in_revert_,
in_escape_handler_, State::instant_suggestion_

[Jered, 2013-06-28 22:30:53]

On 2013/06/28 20:50:54, Peter Kasting wrote:
> I don't know how many pieces you want to try and pull out now.  Here are some
> more bits that are or may be dead:
> 
> OmniboxController: gray_suggestion_, gray_suggestion(), SetInstantSuggestion()
gray_suggestion() seems easy enough, killed.
SetInstantSuggestion() takes a tour through a bunch of view code so
I prefer to leave that as a followup (I added a TODO for it).

> 
> OmniboxEditModel: CommitSuggestedText(), GetInstantController(), in_revert_,
> in_escape_handler_, State::instant_suggestion_
CommitSuggestedText() also takes me into view code.
GetInstantController() is still used.
I think in_revert_ may frighteningly still be needed because it's passed
to NotifySearchTabHelper() which is still a thing.
Deleted in_escape_handler_.
I prefer to leave instant_suggestion for the follow-up CL in which I
remove SetInstantSuggestion().

[Peter Kasting, 2013-06-28 22:32:18]

OK, LGTM.

(This change makes me think of http://cdn.meme.li/instances/400x/34781482.jpg .)

[samarth, 2013-07-02 21:14:15]

Phew, that's a lot of dead code. Most of my comments are suggestions for more
cleanup, which we can definitely do in follow-up CLs.

In particular, we should remove the dead fields/functions from the searchbox API
(along with associated renderer code).

I'll play with this patch to make sure we don't have any behavioral regressions
and then l g t m.

Thanks,
Samarth

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_edit_model.h (left):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_edit_model.h:538: // This is needed as prior
to accepting the current text the model is
We may also be able to kill in_revert_.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_controller.cc (left):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.cc:311: bool
InstantController::Update(const AutocompleteMatch& match,
Yay!

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_controller.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.cc:282: void
InstantController::TabDeactivated(content::WebContents* contents) {
Can just remove this function.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.cc:557: if (extended_enabled())
Why add this? If anything, we should be killing these everywhere.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_controller.h (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.h:110: // Loads a new NTP to replace
|ntp_|.
Can we keep this private if it's only used in tests?

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_ipc_sender.cc (left):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_ipc_sender.cc:80: virtual void
SetDisplayInstantResults(bool display_instant_results) OVERRIDE {
We should make sure the server isn't relying on this bit being set.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_ipc_sender.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_ipc_sender.cc:27: virtual void
SetFontInformation(const string16& omnibox_font_name,
Can this go?

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_overlay_model.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_overlay_model.cc:1: // Copyright 2012 The
Chromium Authors. All rights reserved.
Can we not kill this entirely?

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_page.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_page.cc:45: void InstantPage::InitializeFonts()
{
Can we kill this?

[samarth, 2013-07-02 21:22:29]

Also, please rebase. This doesn't apply at head anymore.

[Jered, 2013-07-02 22:03:11]

Ok rebased... some responses below, thanks.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_edit_model.h (left):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_edit_model.h:538: // This is needed as prior
to accepting the current text the model is
On 2013/07/02 21:14:15, samarth wrote:
> We may also be able to kill in_revert_.

I started trying but it's used by SearchTabHelper for something or another, so
didn't want to go there in this CL.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_controller.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.cc:282: void
InstantController::TabDeactivated(content::WebContents* contents) {
On 2013/07/02 21:14:15, samarth wrote:
> Can just remove this function.

I kept it in anticipation of https://codereview.chromium.org/17526008/ which I
assumed would be checked in before this. I'll just leave it for now... :-)

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.cc:557: if (extended_enabled())
On 2013/07/02 21:14:15, samarth wrote:
> Why add this? If anything, we should be killing these everywhere.

This is called from BrowserInstantController now without checking that
condition. Separately, it probably makes sense to have that and this not exist
at all if "extended" is not enabled (and to do something about the name
"InstantExtended", since Instant doesn't exist as such and we're not extending
it).

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_controller.h (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_controller.h:110: // Loads a new NTP to replace
|ntp_|.
On 2013/07/02 21:14:15, samarth wrote:
> Can we keep this private if it's only used in tests?

This is now called by BrowserInstantController instead of SetInstantEnabled().

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_ipc_sender.cc (left):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_ipc_sender.cc:80: virtual void
SetDisplayInstantResults(bool display_instant_results) OVERRIDE {
On 2013/07/02 21:14:15, samarth wrote:
> We should make sure the server isn't relying on this bit being set.

It can't be set, because Instant is disabled, right?

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_ipc_sender.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_ipc_sender.cc:27: virtual void
SetFontInformation(const string16& omnibox_font_name,
On 2013/07/02 21:14:15, samarth wrote:
> Can this go?

The online ntp is still (erronously I think) using it for theme attribution
text.

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_overlay_model.cc (right):

https://codereview.chromium.org/18223002/diff/28001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_overlay_model.cc:1: // Copyright 2012 The
Chromium Authors. All rights reserved.
On 2013/07/02 21:14:15, samarth wrote:
> Can we not kill this entirely?

I tried, but doing so also requires deleting a bunch of view code, which I'd
prefer to do as a followup.

[samarth, 2013-07-02 22:45:51]

lgtm

[Jered, 2013-07-03 16:25:19]

TBR brettw for the misc browser stuff.

[commit-bot: I haz the power, 2013-07-03 16:25:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jered@chromium.org/18223002/41001

[commit-bot: I haz the power, 2013-07-03 16:25:58]

Failed to apply patch for chrome/browser/ui/search/instant_controller.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/search/instant_controller.cc
  Hunk #11 FAILED at 243.
  Hunk #12 succeeded at 291 (offset 5 lines).
  Hunk #13 succeeded at 298 (offset 5 lines).
  Hunk #14 succeeded at 313 (offset 5 lines).
  Hunk #15 succeeded at 335 (offset 5 lines).
  Hunk #16 succeeded at 376 (offset 5 lines).
  Hunk #17 succeeded at 389 (offset 5 lines).
  Hunk #18 succeeded at 410 (offset 5 lines).
  Hunk #19 succeeded at 461 (offset 5 lines).
  Hunk #20 succeeded at 478 (offset 5 lines).
  Hunk #21 succeeded at 487 (offset 5 lines).
  Hunk #22 succeeded at 529 (offset 5 lines).
  Hunk #23 succeeded at 541 (offset 5 lines).
  Hunk #24 succeeded at 591 (offset 5 lines).
  Hunk #25 succeeded at 617 (offset 5 lines).
  Hunk #26 succeeded at 625 (offset 5 lines).
  Hunk #27 succeeded at 633 (offset 5 lines).
  Hunk #28 succeeded at 655 (offset 5 lines).
  Hunk #29 succeeded at 670 (offset 5 lines).
  1 out of 29 hunks FAILED -- saving rejects to file
chrome/browser/ui/search/instant_controller.cc.rej

Patch:       chrome/browser/ui/search/instant_controller.cc
Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc
b/chrome/browser/ui/search/instant_controller.cc
index
cae96060ec4c6f4ba2240494300524ee76509966..ab1d5c0a2c6e70467942fa58545b941896cabb96
100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -4,22 +4,13 @@
 
 #include "chrome/browser/ui/search/instant_controller.h"
 
-#include <iterator>
-
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
-#include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
-#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/autocomplete/autocomplete_provider.h"
-#include "chrome/browser/autocomplete/autocomplete_result.h"
-#include "chrome/browser/autocomplete/search_provider.h"
 #include "chrome/browser/content_settings/content_settings_provider.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
-#include "chrome/browser/history/history_service.h"
-#include "chrome/browser/history/history_service_factory.h"
-#include "chrome/browser/history/history_tab_helper.h"
 #include "chrome/browser/platform_util.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/instant_service.h"
 #include "chrome/browser/search/instant_service_factory.h"
 #include "chrome/browser/search/search.h"
@@ -28,7 +19,6 @@
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/ui/browser_instant_controller.h"
 #include "chrome/browser/ui/search/instant_ntp.h"
-#include "chrome/browser/ui/search/instant_overlay.h"
 #include "chrome/browser/ui/search/instant_tab.h"
 #include "chrome/browser/ui/search/search_tab_helper.h"
 #include "chrome/common/chrome_notification_types.h"
@@ -46,7 +36,6 @@
 #include "content/public/browser/web_contents_view.h"
 #include "net/base/escape.h"
 #include "net/base/network_change_notifier.h"
-#include "third_party/icu/public/common/unicode/normalizer2.h"
 
 #if defined(TOOLKIT_VIEWS)
 #include "ui/views/widget/widget.h"
@@ -54,11 +43,6 @@
 
 namespace {
 
-// An artificial delay (in milliseconds) we introduce before telling the
Instant
-// page about the new omnibox bounds, in cases where the bounds shrink. This is
-// to avoid the page jumping up/down very fast in response to bounds changes.
-const int kUpdateBoundsDelayMS = 1000;
-
 // For reporting Instant navigations.
 enum InstantNavigation {
   INSTANT_NAVIGATION_LOCAL_CLICK = 0,
@@ -85,128 +69,6 @@ void RecordNavigationHistogram(bool is_local, bool is_click,
bool is_extended) {
                             INSTANT_NAVIGATION_MAX);
 }
 
-void RecordFallbackReasonHistogram(
-    const InstantController::InstantFallbackReason fallback_reason) {
-  UMA_HISTOGRAM_ENUMERATION("InstantExtended.FallbackToLocalOverlay",
-                            fallback_reason,
-                            InstantController::INSTANT_FALLBACK_MAX);
-}
-
-InstantController::InstantFallbackReason DetermineFallbackReason(
-    const InstantPage* page, std::string instant_url) {
-  InstantController::InstantFallbackReason fallback_reason;
-  if (!page) {
-    fallback_reason = InstantController::INSTANT_FALLBACK_NO_OVERLAY;
-  } else if (instant_url.empty()) {
-    fallback_reason = InstantController::INSTANT_FALLBACK_INSTANT_URL_EMPTY;
-  } else if (!chrome::MatchesOriginAndPath(GURL(page->instant_url()),
-                                           GURL(instant_url))) {
-    fallback_reason = InstantController::INSTANT_FALLBACK_ORIGIN_PATH_MISMATCH;
-  } else if (!page->supports_instant()) {
-    fallback_reason =
InstantController::INSTANT_FALLBACK_INSTANT_NOT_SUPPORTED;
-  } else {
-    fallback_reason = InstantController::INSTANT_FALLBACK_UNKNOWN;
-  }
-  return fallback_reason;
-}
-
-void AddSessionStorageHistogram(bool extended_enabled,
-                                const content::WebContents* tab1,
-                                const content::WebContents* tab2) {
-  base::HistogramBase* histogram = base::BooleanHistogram::FactoryGet(
-      std::string("Instant.SessionStorageNamespace") +
-          (extended_enabled ? "_Extended" : "_Instant"),
-      base::HistogramBase::kUmaTargetedHistogramFlag);
-  const content::SessionStorageNamespaceMap& session_storage_map1 =
-      tab1->GetController().GetSessionStorageNamespaceMap();
-  const content::SessionStorageNamespaceMap& session_storage_map2 =
-      tab2->GetController().GetSessionStorageNamespaceMap();
-  bool is_session_storage_the_same =
-      session_storage_map1.size() == session_storage_map2.size();
-  if (is_session_storage_the_same) {
-    // The size is the same, so let's check that all entries match.
-    for (content::SessionStorageNamespaceMap::const_iterator
-             it1 = session_storage_map1.begin(),
-             it2 = session_storage_map2.begin();
-         it1 != session_storage_map1.end() && it2 !=
session_storage_map2.end();
-         ++it1, ++it2) {
-      if (it1->first != it2->first || it1->second.get() != it2->second.get()) {
-        is_session_storage_the_same = false;
-        break;
-      }
-    }
-  }
-  histogram->AddBoolean(is_session_storage_the_same);
-}
-
-string16 Normalize(const string16& str) {
-  UErrorCode status = U_ZERO_ERROR;
-  const icu::Normalizer2* normalizer =
-      icu::Normalizer2::getInstance(NULL, "nfkc_cf", UNORM2_COMPOSE, status);
-  if (normalizer == NULL || U_FAILURE(status))
-    return str;
-  icu::UnicodeString norm_str(normalizer->normalize(
-      icu::UnicodeString(FALSE, str.c_str(), str.size()), status));
-  if (U_FAILURE(status))
-    return str;
-  return string16(norm_str.getBuffer(), norm_str.length());
-}
-
-bool NormalizeAndStripPrefix(string16* text, const string16& prefix) {
-  string16 norm_prefix = Normalize(prefix);
-  string16 norm_text = Normalize(*text);
-  if (norm_prefix.size() <= norm_text.size() &&
-      norm_text.compare(0, norm_prefix.size(), norm_prefix) == 0) {
-    *text = norm_text.erase(0, norm_prefix.size());
-    return true;
-  }
-  return false;
-}
-
-// For TOOLKIT_VIEWS, the top level widget is always focused. If the focus
-// change originated in views determine the child Widget from the view that is
-// being focused.
-gfx::NativeView GetViewGainingFocus(gfx::NativeView view_gaining_focus) {
-#if defined(TOOLKIT_VIEWS)
-  views::Widget* widget = view_gaining_focus ?
-      views::Widget::GetWidgetForNativeView(view_gaining_focus) : NULL;
-  if (widget) {
-    views::FocusManager* focus_manager = widget->GetFocusManager();
-    if (focus_manager && focus_manager->is_changing_focus() &&
-        focus_manager->GetFocusedView() &&
-        focus_manager->GetFocusedView()->GetWidget())
-      return focus_manager->GetFocusedView()->GetWidget()->GetNativeView();
-  }
-#endif
-  return view_gaining_focus;
-}
-
-// Returns true if |view| is the top-level contents view or a child view in the
-// view hierarchy of |contents|.
-bool IsViewInContents(gfx::NativeView view, content::WebContents* contents) {
-  content::RenderWidgetHostView* rwhv = contents->GetRenderWidgetHostView();
-  if (!view || !rwhv)
-    return false;
-
-  gfx::NativeView tab_view = contents->GetView()->GetNativeView();
-  if (view == rwhv->GetNativeView() || view == tab_view)
-    return true;
-
-  // Walk up the view hierarchy to determine if the view is a subview of the
-  // WebContents view (such as a windowed plugin or http auth dialog).
-  while (view) {
-    view = platform_util::GetParent(view);
-    if (view == tab_view)
-      return true;
-  }
-
-  return false;
-}
-
-bool IsFullHeight(const InstantOverlayModel& model) {
-  return model.height() == 100 && model.height_units() == INSTANT_SIZE_PERCENT;
-}
-
 bool IsContentsFrom(const InstantPage* page,
                     const content::WebContents* contents) {
   return page && (page->contents() == contents);
@@ -256,19 +118,9 @@
InstantController::InstantController(BrowserInstantController* browser,
                                      bool extended_enabled)
     : browser_(browser),
       extended_enabled_(extended_enabled),
-      instant_enabled_(false),
-      use_local_page_only_(true),
-      preload_ntp_(true),
-      model_(this),
-      use_tab_for_suggestions_(false),
-      last_omnibox_text_has_inline_autocompletion_(false),
-      last_verbatim_(false),
-      last_transition_type_(content::PAGE_TRANSITION_LINK),
-      last_match_was_search_(false),
       omnibox_focus_state_(OMNIBOX_FOCUS_NONE),
       omnibox_focus_change_reason_(OMNIBOX_FOCUS_CHANGE_EXPLICIT),
-      omnibox_bounds_(-1, -1, 0, 0),
-      allow_overlay_to_show_search_suggestions_(false) {
+      omnibox_bounds_(-1, -1, 0, …
(message too large)

[commit-bot: I haz the power, 2013-07-03 16:30:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jered@chromium.org/18223002/45001

[commit-bot: I haz the power, 2013-07-03 16:56:47]

Retried try job too often on win_x64_rel for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-07-03 16:59:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jered@chromium.org/18223002/67002

[commit-bot: I haz the power, 2013-07-03 17:30:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-07-03 17:33:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jered@chromium.org/18223002/77001

[commit-bot: I haz the power, 2013-07-03 20:32:14]

Change committed as 210036

[brettw, 2013-07-11 18:10:16]

lgtm