Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: chrome/browser/ui/search/instant_page.cc

Issue 18223002: InstantExtended: Remove overlay control code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Call renamed method. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/instant_page.h ('k') | chrome/browser/ui/search/instant_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_page.cc
diff --git a/chrome/browser/ui/search/instant_page.cc b/chrome/browser/ui/search/instant_page.cc
index c8aa8c6db87b98f6f5a05d6e67af50bae81f6d1c..121300ad0466891bb21f7b6e81ae37b83ed315e9 100644
--- a/chrome/browser/ui/search/instant_page.cc
+++ b/chrome/browser/ui/search/instant_page.cc
@@ -89,14 +89,6 @@ bool InstantPage::ShouldProcessAboutToNavigateMainFrame() {
return false;
}
-bool InstantPage::ShouldProcessSetSuggestions() {
- return false;
-}
-
-bool InstantPage::ShouldProcessShowInstantOverlay() {
- return false;
-}
-
bool InstantPage::ShouldProcessFocusOmnibox() {
return false;
}
@@ -123,9 +115,6 @@ bool InstantPage::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(InstantPage, message)
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SetSuggestions, OnSetSuggestions)
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_ShowInstantOverlay,
- OnShowInstantOverlay)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_FocusOmnibox, OnFocusOmnibox)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxNavigate,
OnSearchBoxNavigate);
@@ -185,33 +174,6 @@ void InstantPage::InstantSupportDetermined(bool supports_instant) {
ClearContents();
}
-void InstantPage::OnSetSuggestions(
- int page_id,
- const std::vector<InstantSuggestion>& suggestions) {
- if (!contents()->IsActiveEntry(page_id))
- return;
-
- SearchTabHelper::FromWebContents(contents())->InstantSupportChanged(true);
- if (!ShouldProcessSetSuggestions())
- return;
-
- delegate_->SetSuggestions(contents(), suggestions);
-}
-
-void InstantPage::OnShowInstantOverlay(int page_id,
- int height,
- InstantSizeUnits units) {
- if (!contents()->IsActiveEntry(page_id))
- return;
-
- SearchTabHelper::FromWebContents(contents())->InstantSupportChanged(true);
- delegate_->LogDropdownShown();
- if (!ShouldProcessShowInstantOverlay())
- return;
-
- delegate_->ShowInstantOverlay(contents(), height, units);
-}
-
void InstantPage::OnFocusOmnibox(int page_id, OmniboxFocusState state) {
if (!contents()->IsActiveEntry(page_id))
return;
« no previous file with comments | « chrome/browser/ui/search/instant_page.h ('k') | chrome/browser/ui/search/instant_page_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698