Remove a duplicate include of about_welcome_android.css

Remove a duplicate include of about_welcome_android.css

Due to flattenhtml="true" we were including 8 copies of the holo_logo.

BUG=326023
TBR=thestig

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253987

[aurimas (slooooooooow), 2014-02-26 22:18:42]

Hey Newton,

Please take a look at this change.

Thanks,
Aurimas

[newt (away), 2014-02-26 22:40:16]

lgtm. good find!

[aurimas (slooooooooow), 2014-02-26 22:44:11]

thakis@chromium.org PTAL

[aurimas (slooooooooow), 2014-02-26 23:41:12]

thestig@chromium.org PTAL

[aurimas (slooooooooow), 2014-02-27 01:33:31]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-02-27 01:36:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/182213002/20001

[commit-bot: I haz the power, 2014-02-27 07:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-27 07:20:18]

Try jobs failed on following builders: mac_chromium_rel

[aurimas (slooooooooow), 2014-02-27 22:43:06]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-02-27 22:43:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/182213002/20001

[commit-bot: I haz the power, 2014-02-28 00:45:45]

Change committed as 253987

[Nico, 2014-03-04 00:09:20]

Nice!

https://chromiumcodereview.appspot.com/182213002/diff/20001/chrome/browser/br...
File chrome/browser/browser_resources.grd (left):

https://chromiumcodereview.appspot.com/182213002/diff/20001/chrome/browser/br...
chrome/browser/browser_resources.grd:24: <structure name="IDR_ABOUT_WELCOME_CSS"
file="resources\about_welcome_android\about_welcome_android.css"
flattenhtml="true" type="chrome_html" />
Add "Remove unused IDR_ABOUT_WELCOME_CSS; the css file is already inlined into
the one html file using it"

https://chromiumcodereview.appspot.com/182213002/diff/20001/chrome/browser/re...
File chrome/browser/resources/about_welcome_android/about_welcome_android.css
(right):

https://chromiumcodereview.appspot.com/182213002/diff/20001/chrome/browser/re...
chrome/browser/resources/about_welcome_android/about_welcome_android.css:76:
background-image: url(images/holo_logo_200.png);
This looks slightly wrong: The way we usually do highres images for resources is
to have images/holo_logo.png with the 1x image and images/2x/holo_logo.png with
the 2x, and then grit will automatically insert a -webkit-image-set with both.
If you only want a single image and no 1x version, then that image shouldn't
contain _200 in its name, it should only be called holo_logo.png


(There's also a holo_logo_150.png in the same folder, is that not used?)

https://chromiumcodereview.appspot.com/182213002/diff/20001/chrome/browser/re...
File chrome/browser/resources/about_welcome_android/about_welcome_android.html
(left):

https://chromiumcodereview.appspot.com/182213002/diff/20001/chrome/browser/re...
chrome/browser/resources/about_welcome_android/about_welcome_android.html:11:
<script src="chrome://welcome/about_welcome_android.js"></script>
This seems unrelated to the CL description. Update the CL description to explain
why you're changing this.

[Nico, 2014-03-04 00:10:33]

…oh, this landed already :-/ (the thread in my inbox only said "thakis, PTAL", I
didn't get an email about this landing.) Nevermind the comment about the CL
description then I suppose, but the other comment can still be addressed.

[Lei Zhang, 2014-03-10 19:16:07]

On 2014/03/04 00:10:33, Nico wrote:
> …oh, this landed already :-/ (the thread in my inbox only said "thakis, PTAL",
I
> didn't get an email about this landing.) Nevermind the comment about the CL
> description then I suppose, but the other comment can still be addressed.

(Back from vacation pong) It looks like Nico reviewed this already, so I won't
review this. It looks like Nico's comments should be addressed though.