Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18196004: Revert 153294 "Remove AtomicStringImpl." (Closed)

Created:
7 years, 5 months ago by Chris Evans
Modified:
7 years, 5 months ago
Reviewers:
Chris Evans
CC:
blink-reviews
Visibility:
Public.

Description

Revert 153294 "Remove AtomicStringImpl." > Remove AtomicStringImpl. > > We believe it's a nop, and a confusing one at that. > > BUG=250050 > > Review URL: https://chromiumcodereview.appspot.com/18228003 TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -126 lines) Patch
M trunk/Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/CSSSelector.h View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/css/CSSSelector.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/RuleFeature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/css/RuleFeature.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/Source/core/css/RuleSet.h View 2 chunks +7 lines, -7 lines 0 comments Download
M trunk/Source/core/css/RuleSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/SelectorChecker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/css/StyleInvalidationAnalysis.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/css/StyleInvalidationAnalysis.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/Source/core/dom/CheckedRadioButtons.h View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/Source/core/dom/CheckedRadioButtons.cpp View 1 chunk +1 line, -1 line 0 comments Download
MM trunk/Source/core/dom/DocumentOrderedMap.h View 2 chunks +16 lines, -16 lines 0 comments Download
MM trunk/Source/core/dom/DocumentOrderedMap.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M trunk/Source/core/dom/Element.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
MM trunk/Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/TreeScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/dom/TreeScope.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
MM trunk/Source/core/editing/MarkupAccumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/MarkupAccumulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
MM trunk/Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/FormController.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/FormController.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M trunk/Source/core/html/HTMLCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/HTMLDocument.h View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/Source/core/html/HTMLDocument.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/page/animation/CompositeAnimation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/page/animation/CompositeAnimation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/rendering/svg/SVGPathData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/scripts/make_names.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
MM trunk/Source/core/svg/SVGStyledElement.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/svg/SVGStyledElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
MM trunk/Source/core/svg/properties/SVGAnimatedPropertyDescription.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/wtf/Forward.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/Source/wtf/HashTable.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/wtf/text/AtomicString.h View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/Source/wtf/text/AtomicString.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + trunk/Source/wtf/text/AtomicStringImpl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/Source/wtf/text/StringImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
7 years, 5 months ago (2013-07-01 21:56:08 UTC) #1
Chris Evans
7 years, 5 months ago (2013-07-01 21:56:31 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r153373.

Powered by Google App Engine
This is Rietveld 408576698