Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18228003: Remove AtomicStringImpl. (Closed)

Created:
7 years, 5 months ago by Chris Evans
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, Steve Block, do-not-use, Nils Barth (inactive), alancutter (OOO until 2018), marja+watch_chromium.org, yurys+blink_chromium.org, abarth-chromium, dstockwell, dglazkov+blink, jchaffraix+rendering, kenneth.christiansen, loislo+blink_chromium.org, darktears, haraken, Nate Chapin, jsbell+bindings_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney, jeez
Visibility:
Public.

Description

Remove AtomicStringImpl. We believe it's a nop, and a confusing one at that. BUG=250050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153294

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -170 lines) Patch
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/RuleSet.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CheckedRadioButtons.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CheckedRadioButtons.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormController.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/animation/CompositeAnimation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/animation/CompositeAnimation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGPathData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/scripts/make_names.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyledElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyledElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyDescription.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Forward.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/wtf/HashTable.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/text/AtomicString.h View 3 chunks +2 lines, -4 lines 1 comment Download
M Source/wtf/text/AtomicString.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/wtf/text/AtomicStringImpl.h View 1 chunk +0 lines, -38 lines 0 comments Download
Source/wtf/text/StringImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
7 years, 5 months ago (2013-06-28 23:18:08 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/18228003/diff/1/Source/wtf/text/AtomicString.h File Source/wtf/text/AtomicString.h (left): https://codereview.chromium.org/18228003/diff/1/Source/wtf/text/AtomicString.h#oldcode60 Source/wtf/text/AtomicString.h:60: AtomicString(AtomicStringImpl* imp) : m_string(imp) { } This constructor ...
7 years, 5 months ago (2013-06-28 23:34:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/18228003/1
7 years, 5 months ago (2013-06-29 01:42:47 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-06-29 03:43:13 UTC) #4
Message was sent while issue was closed. 
Change committed as 153294

Powered by Google App Engine
This is Rietveld 408576698