Issue 18178006: Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18178006: Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now). (Closed)

Created:
7 years, 5 months ago by nasko

Modified:
7 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, chromium-site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now). This is reland of https://codereview.chromium.org/17114006/, which was reverted due to bug in WebFrameTestProxy. I've fixed the issue in https://codereview.chromium.org/18031013/. BUG=245126 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209733

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -25 lines)			Patch
M	content/renderer/render_frame_impl.h	View	1	3 chunks	+12 lines, -10 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View		2 chunks	+25 lines, -11 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
M	content/test/layouttest_support.cc	View		4 chunks	+17 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

nasko

Hey Jochen, Can you review this change for me? This is another attempt at landing ...

7 years, 5 months ago (2013-07-02 04:30:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/18178006/3001

7 years, 5 months ago (2013-07-02 14:07:48 UTC) #3

Message was sent while issue was closed.

Change committed as 209733