Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 18153015: Stop creating shortcut for web apps when it is installing. (Closed)

Created:
7 years, 5 months ago by zhchbin
Modified:
7 years, 5 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Stop creating shortcut for web apps when it is installing. BUG=255413 TEST=1.Launch Chrome; 2.Add an app from web store eg: (https://chrome.google.com/webstore/detail/shoot-many-robots-arena-k/gejophacjbklkgfilkoaeniiooobobkf?utm_source=chrome-ntp-icon). ; 3.When app downloading is in process drag the icon of the app out of the app launcher, the chrome should not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209944

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
zhchbin
Please review.
7 years, 5 months ago (2013-06-29 03:05:20 UTC) #1
zhchbin
On 2013/06/29 03:05:20, zhchbin wrote: > Please review. Ping again.
7 years, 5 months ago (2013-07-03 03:32:02 UTC) #2
koz (OOO until 15th September)
lgtm once the comment is removed https://chromiumcodereview.appspot.com/18153015/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://chromiumcodereview.appspot.com/18153015/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode106 chrome/browser/ui/app_list/app_list_view_delegate.cc:106: // The installation ...
7 years, 5 months ago (2013-07-03 04:20:08 UTC) #3
zhchbin
https://chromiumcodereview.appspot.com/18153015/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://chromiumcodereview.appspot.com/18153015/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode106 chrome/browser/ui/app_list/app_list_view_delegate.cc:106: // The installation of extension isn't finished yet. On ...
7 years, 5 months ago (2013-07-03 05:59:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/18153015/6001
7 years, 5 months ago (2013-07-03 06:00:19 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-03 08:13:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/18153015/6001
7 years, 5 months ago (2013-07-03 08:18:04 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 10:13:19 UTC) #8
Message was sent while issue was closed.
Change committed as 209944

Powered by Google App Engine
This is Rietveld 408576698