chrome/browser/ui/app_list/app_list_view_delegate.cc - Issue 18153015: Stop creating shortcut for web apps when it is installing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_view_delegate.cc

Issue 18153015: Stop creating shortcut for web apps when it is installing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove comment. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/app_list_view_delegate.cc

diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.cc b/chrome/browser/ui/app_list/app_list_view_delegate.cc

index 7b59b98f77fd6631d34ba5e7c347ada5dfb5f160..ee4769fc650c333695c975dc3b291ad0fd8c40c5 100644

--- a/chrome/browser/ui/app_list/app_list_view_delegate.cc

+++ b/chrome/browser/ui/app_list/app_list_view_delegate.cc

@@ -102,7 +102,10 @@ void AppListViewDelegate::GetShortcutPathForApp(

DCHECK(service);

const extensions::Extension* extension =

service->GetInstalledExtension(app_id);

- DCHECK(extension);

+ if (!extension) {

+ callback.Run(base::FilePath());

+ return;

+ }

base::FilePath app_data_dir(

web_app::GetWebAppDataDirectory(profile_->GetPath(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »