Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 18112005: silence qcms __force_align_arg_pointer__ warning on mips too (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

silence qcms __force_align_arg_pointer__ warning on mips too Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/qcms/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/qcms/google.patch View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/qcms/src/transform.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Mostyn Bramley-Moore
This small patch is an extension of this previous CL: https://chromiumcodereview.appspot.com/11365242
7 years, 5 months ago (2013-06-27 22:51:08 UTC) #1
Sam Clegg
lgtm. That list is getting long now, might be better to invert it?
7 years, 5 months ago (2013-06-27 23:22:04 UTC) #2
Nico
lgtm
7 years, 5 months ago (2013-06-27 23:23:00 UTC) #3
Mostyn Bramley-Moore
On 2013/06/27 23:22:04, Sam Clegg wrote: > That list is getting long now, might be ...
7 years, 5 months ago (2013-06-28 05:49:43 UTC) #4
Sam Clegg
On 2013/06/28 05:49:43, Mostyn Bramley-Moore wrote: > On 2013/06/27 23:22:04, Sam Clegg wrote: > > ...
7 years, 5 months ago (2013-06-28 14:56:03 UTC) #5
Sam Clegg
On 2013/06/28 14:56:03, Sam Clegg wrote: > On 2013/06/28 05:49:43, Mostyn Bramley-Moore wrote: > > ...
7 years, 5 months ago (2013-07-01 23:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18112005/1
7 years, 5 months ago (2013-07-02 07:03:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=13394
7 years, 5 months ago (2013-07-02 07:17:12 UTC) #8
Mostyn Bramley-Moore
Hmm, no OWNERS for third_party/qcms ... @cpu: can you give this a thumbs-up?
7 years, 5 months ago (2013-07-02 07:29:39 UTC) #9
cpu_(ooo_6.6-7.5)
lgtm. In the future you don't need root owners approval for changes in third party, ...
7 years, 5 months ago (2013-07-02 20:04:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18112005/1
7 years, 5 months ago (2013-07-02 20:21:14 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 23:34:06 UTC) #12
Message was sent while issue was closed.
Change committed as 209815

Powered by Google App Engine
This is Rietveld 408576698