Fix compiler warning in qcms with gcc/arm

Fix gcc/arm compiler warning in qcms


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168271

[Sam Clegg, 2012-11-14 00:41:38]

Split from http://codereview.chromium.org/11360238/.

Hand edited patch.

[Nico, 2012-11-15 18:55:22]

http://codereview.chromium.org/11365242/diff/1/third_party/qcms/src/transform.c
File third_party/qcms/src/transform.c (right):

http://codereview.chromium.org/11365242/diff/1/third_party/qcms/src/transform...
third_party/qcms/src/transform.c:1338: #endif
What I meant was something like this:

#if !defined(__has_attribute)
#if defined(__GNUC__) && !defined(__x86_64__) && !defined(__amd64__) && !defined
(__arm__)
#define __has_attribute(x) 1
#else
#define __has_attribute(x) 0

…but this is probably cleaner:

#if defined(__has_attribute)
#define HAS_FORCEALIGN __has_attribute(__force_align_arg_pointer__)
#elif defined(__GNUC__) && !defined(__x86_64__) && !defined(__amd64__) &&
!defined (__arm__)
#define HAS_FORCEALIGN 1
#else
#define HAS_FORCEALIGN 0
#endif

#if HAS_FORCEALIGN)
__attribute__((__force_align_arg_pointer__))
#endif

[Sam Clegg, 2012-11-15 19:43:04]

On 2012/11/15 18:55:22, Nico wrote:
>
http://codereview.chromium.org/11365242/diff/1/third_party/qcms/src/transform.c
> File third_party/qcms/src/transform.c (right):
> 
>
http://codereview.chromium.org/11365242/diff/1/third_party/qcms/src/transform...
> third_party/qcms/src/transform.c:1338: #endif
> What I meant was something like this:
> 
> #if !defined(__has_attribute)
> #if defined(__GNUC__) && !defined(__x86_64__) && !defined(__amd64__) &&
!defined
> (__arm__)
> #define __has_attribute(x) 1
> #else
> #define __has_attribute(x) 0
> 
> …but this is probably cleaner:
> 
> #if defined(__has_attribute)
> #define HAS_FORCEALIGN __has_attribute(__force_align_arg_pointer__)
> #elif defined(__GNUC__) && !defined(__x86_64__) && !defined(__amd64__) &&
> !defined (__arm__)
> #define HAS_FORCEALIGN 1
> #else
> #define HAS_FORCEALIGN 0
> #endif
> 
> #if HAS_FORCEALIGN)
> __attribute__((__force_align_arg_pointer__))
> #endif

Ok, will do, was trying to keep the change simple so I didn't have
to go hunting for the upstream version of qcms to re-generate the
patch.   But I'll stop being lazy and go do that.

[Sam Clegg, 2012-11-15 20:52:42]

PTAL

Now we use __has_attribute iff it exists and fall back
to defines.

Also, regenerate the full patch file, and add instructions
on doing so.

[Nico, 2012-11-15 21:01:42]

lgtm

Thanks!

[commit-bot: I haz the power, 2012-11-15 22:54:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11365242/9001

[commit-bot: I haz the power, 2012-11-16 18:21:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11365242/9001

[commit-bot: I haz the power, 2012-11-16 20:09:57]

Change committed as 168271