Implemented types.private.ChromeDirectSetting.onChange

Implemented types.private.ChromeDirectSetting.onChange

This delta links up the onChange event machinery to the property
change notification machinery.

It follows a pattern established in PreferencesAPI and the
PreferenceEventRouter.
* Given a list of preferences, register event listener added
  observers to each preference.
* On the first added event listener, unregister all observers
  and register all property change listeners.
* On property changes, forward an event to each component
  extension that has a property listener added.

BUG=164227
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212307

[robliao, 2013-07-13 00:33:35]

https://codereview.chromium.org/18100007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/preference/chrome_direct_setting_api.h
(right):

https://codereview.chromium.org/18100007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/preference/chrome_direct_setting_api.h:59: #endif 
// CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_API_H__
This line will fail presubmit (81 characters). Any recommendations on how to fix
this?

[vadimt, 2013-07-13 00:40:09]

Please proceed with file owners; thanks!

https://codereview.chromium.org/18100007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/preference/chrome_direct_setting_api.h
(right):

https://codereview.chromium.org/18100007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/preference/chrome_direct_setting_api.h:59: #endif 
// CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_API_H__
On 2013/07/13 00:33:35, Robert Liao wrote:
> This line will fail presubmit (81 characters). Any recommendations on how to
fix
> this?

You can try to find another file with a long name and see how it was landed...

[robliao, 2013-07-15 17:14:40]

https://codereview.chromium.org/18100007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/preference/chrome_direct_setting_api.h
(right):

https://codereview.chromium.org/18100007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/preference/chrome_direct_setting_api.h:59: #endif 
// CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_API_H__
Existing files appear to be directly submitted or before chromium_presubmit.
On 2013/07/13 00:40:09, vadimt wrote:
> On 2013/07/13 00:33:35, Robert Liao wrote:
> > This line will fail presubmit (81 characters). Any recommendations on how to
> fix
> > this?
> 
> You can try to find another file with a long name and see how it was landed...

[robliao, 2013-07-15 17:15:41]

Please provide owner approval for the files listed under your name. Thanks!

miket:
chrome/browser/extensions/api/preference/chrome_direct_setting.h     
chrome/browser/extensions/api/preference/chrome_direct_setting.cc    
chrome/browser/extensions/api/preference/chrome_direct_setting_api.h 
chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

erg:
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc  

sky:
chrome/chrome_browser_extensions.gypi

[Elliot Glaysher, 2013-07-15 17:31:32]

profiles lgtm stamp

[sky, 2013-07-15 19:58:26]

.gypi LGTM

[miket_OOO, 2013-07-15 23:35:26]

> chrome/browser/extensions/api/preference/chrome_direct_setting.h     
> chrome/browser/extensions/api/preference/chrome_direct_setting.cc    
> chrome/browser/extensions/api/preference/chrome_direct_setting_api.h 
> chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

OWNER LGTM

[robliao, 2013-07-16 17:44:57]

All owners approve, proceeding with commit process.

[commit-bot: I haz the power, 2013-07-16 17:49:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/18100007/1

[commit-bot: I haz the power, 2013-07-16 19:43:59]

Retried try job too often on linux_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-07-16 20:36:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/18100007/1

[commit-bot: I haz the power, 2013-07-17 01:10:04]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-07-17 17:23:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/18100007/1

[commit-bot: I haz the power, 2013-07-18 09:40:49]

Change committed as 212307