Implemented types.private.ChromeDirectSetting.onChange

chrome/browser/extensions/api/preference/chrome_direct_setting_api.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_API_H__
+#define CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_API_H__
+
+#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
+#include "chrome/browser/extensions/event_router.h"
+
+class PrefChangeRegistrar;
+class Profile;
+
+namespace extensions {
+namespace chromedirectsetting {
+
+class ChromeDirectSettingAPI : public ProfileKeyedAPI,
+                               public EventRouter::Observer {
+ public:
+  explicit ChromeDirectSettingAPI(Profile* profile);
+
+  virtual ~ChromeDirectSettingAPI();
+
+  // BrowserContextKeyedService implementation.
+  virtual void Shutdown() OVERRIDE;
+
+  // ProfileKeyedAPI implementation.
+  static ProfileKeyedAPIFactory<ChromeDirectSettingAPI>* GetFactoryInstance();
+
+  // EventRouter::Observer implementation.
+  virtual void OnListenerAdded(const EventListenerInfo& details) OVERRIDE;
+
+  // Returns true if the preference is on the whitelist.
+  bool IsPreferenceOnWhitelist(const std::string& pref_key);
+
+  // Convenience method to get the ChromeDirectSettingAPI for a profile.
+  static ChromeDirectSettingAPI* Get(Profile* profile);
+
+ private:
+  friend class ProfileKeyedAPIFactory<ChromeDirectSettingAPI>;
+
+  // ProfileKeyedAPI implementation.
+  static const char* service_name();
+
+  void OnPrefChanged(PrefService* pref_service, const std::string& pref_key);
+
+  static const bool kServiceIsNULLWhileTesting = true;
+  static const bool kServiceRedirectedInIncognito = false;
+
+  PrefChangeRegistrar registrar_;
+  Profile* profile_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeDirectSettingAPI);
+};
+
+}  // namespace chromedirectsetting
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_PREFERENCE_CHROME_DIRECT_SETTING_API_H__

[robliao, 2013/07/13 00:33:35]

This line will fail presubmit (81 characters). Any recommendations on how to fix
this?

[vadimt, 2013/07/13 00:40:09]

You can try to find another file with a long name and see how it was landed...

[robliao, 2013/07/15 17:14:41]

Existing files appear to be directly submitted or before chromium_presubmit.
On 2013/07/13 00:40:09, vadimt wrote:

+