Issue 18068015: Qualify function calls in NetworkConfigurationUpdater.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18068015: Qualify function calls in NetworkConfigurationUpdater. (Closed)

Created:
7 years, 5 months ago by pneubeck (no reviews)

Modified:
7 years, 5 months ago

Reviewers:
Joao da Silva

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Qualify function calls in NetworkConfigurationUpdater. These call's to unqualified functions worked because of C++'s argument-dependent name lookup. This was very ugly and happened by accident. This commit explicitly qualifies these calls. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210077

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/policy/network_configuration_updater_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/chromeos/policy/network_configuration_updater_impl_cros.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/18068015/1

7 years, 5 months ago (2013-07-03 14:53:22 UTC) #3

Message was sent while issue was closed.

Change committed as 210077

Expand Messages | Collapse Messages