Fixing up DOM constructors.

Fixing up DOM constructors.

This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24619

[sra1, 2013-06-28 21:57:04]

https://chromiumcodereview.appspot.com/18054021/diff/1/sdk/lib/html/html_comm...
File sdk/lib/html/html_common/html_common_dart2js.dart (right):

https://chromiumcodereview.appspot.com/18054021/diff/1/sdk/lib/html/html_comm...
sdk/lib/html/html_common/html_common_dart2js.dart:28: class
NativeFieldWrapperClass1 extends Interceptor {
Why is this here, especially since the classes explicitly extend Interceptor?

https://chromiumcodereview.appspot.com/18054021/diff/1/tools/dom/templates/ht...
File tools/dom/templates/html/dart2js/impl_Console.darttemplate (right):

https://chromiumcodereview.appspot.com/18054021/diff/1/tools/dom/templates/ht...
tools/dom/templates/html/dart2js/impl_Console.darttemplate:7:
$(ANNOTATIONS)$(CLASS_MODIFIERS)class Console {
I don't see where CLASS_MODIFIERS is used

[blois, 2013-06-28 22:32:15]

On 2013/06/28 21:57:04, sra1 wrote:
>
https://chromiumcodereview.appspot.com/18054021/diff/1/sdk/lib/html/html_comm...
> File sdk/lib/html/html_common/html_common_dart2js.dart (right):
> 
>
https://chromiumcodereview.appspot.com/18054021/diff/1/sdk/lib/html/html_comm...
> sdk/lib/html/html_common/html_common_dart2js.dart:28: class
> NativeFieldWrapperClass1 extends Interceptor {
> Why is this here, especially since the classes explicitly extend Interceptor?
> 
>
https://chromiumcodereview.appspot.com/18054021/diff/1/tools/dom/templates/ht...
> File tools/dom/templates/html/dart2js/impl_Console.darttemplate (right):
> 
>
https://chromiumcodereview.appspot.com/18054021/diff/1/tools/dom/templates/ht...
> tools/dom/templates/html/dart2js/impl_Console.darttemplate:7:
> $(ANNOTATIONS)$(CLASS_MODIFIERS)class Console {
> I don't see where CLASS_MODIFIERS is used

Updated, but also took the opportunity to remove our pure_interface.darttemplate
file since it can be replicated using the existing template file (and adds some
missing doc annotations too).

[blois, 2013-06-28 23:38:35]

Removed the changes to Interceptor's constructor and opened bug 11620.

https://chromiumcodereview.appspot.com/18054021/diff/1/sdk/lib/html/html_comm...
File sdk/lib/html/html_common/html_common_dart2js.dart (right):

https://chromiumcodereview.appspot.com/18054021/diff/1/sdk/lib/html/html_comm...
sdk/lib/html/html_common/html_common_dart2js.dart:28: class
NativeFieldWrapperClass1 extends Interceptor {
On 2013/06/28 21:57:04, sra1 wrote:
> Why is this here, especially since the classes explicitly extend Interceptor?

Ack, this was from earlier investigations. Removed.

https://chromiumcodereview.appspot.com/18054021/diff/1/tools/dom/templates/ht...
File tools/dom/templates/html/dart2js/impl_Console.darttemplate (right):

https://chromiumcodereview.appspot.com/18054021/diff/1/tools/dom/templates/ht...
tools/dom/templates/html/dart2js/impl_Console.darttemplate:7:
$(ANNOTATIONS)$(CLASS_MODIFIERS)class Console {
On 2013/06/28 21:57:04, sra1 wrote:
> I don't see where CLASS_MODIFIERS is used

I had added it everywhere because I thought we were moving to abstract classes,
but regardless it is in some of our templates, so this just standardizes them.

[sra1, 2013-06-29 00:12:04]

lgtm

[blois, 2013-06-29 00:15:05]

Committed patchset #2 manually as r24619 (presubmit successful).