Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5359)

Unified Diff: chrome/browser/signin/signin_browsertest.cc

Issue 17962003: Fix regression: only clear sign-in process for navigations in that process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_browsertest.cc
diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc
index 2886c53acef93edc950664b87c24dad1b45c30c6..14ee972e3f4d8491e9a2b46cb2d357a14cfcf87f 100644
--- a/chrome/browser/signin/signin_browsertest.cc
+++ b/chrome/browser/signin/signin_browsertest.cc
@@ -148,7 +148,13 @@ IN_PROC_BROWSER_TEST_F(SigninBrowserTest, NotTrustedAfterRedirect) {
ui_test_utils::NavigateToURL(browser(), url);
EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
- // Navigating away should change the process.
+ // Navigating in a different tab should not affect the sign-in process.
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), GURL(kNonSigninURL), NEW_BACKGROUND_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+ EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
+
+ // Navigating away should clear the sign-in process.
GURL redirect_url("https://accounts.google.com/server-redirect?"
"https://foo.com?service=chromiumsync");
ui_test_utils::NavigateToURL(browser(), redirect_url);
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698