Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 17962003: Fix regression: only clear sign-in process for navigations in that process. (Closed)

Created:
7 years, 6 months ago by Charlie Reis
Modified:
7 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, nasko, tim (not reviewing)
Visibility:
Public.

Description

Fix regression: only clear sign-in process for navigations in that process. BUG=252062 TEST=Navigate in another tab while the first run dialog is showing; no prompt. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/signin/signin_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Charlie Reis
Roger, I need your review on this. This will fix a regression due to https://codereview.chromium.org/17727002/, ...
7 years, 6 months ago (2013-06-26 23:13:44 UTC) #1
Roger Tawa OOO till Jul 10th
On 2013/06/26 23:13:44, creis wrote: > Roger, I need your review on this. This will ...
7 years, 5 months ago (2013-06-27 13:22:40 UTC) #2
Charlie Reis
On 2013/06/27 13:22:40, Roger Tawa wrote: > On 2013/06/26 23:13:44, creis wrote: > > Roger, ...
7 years, 5 months ago (2013-06-27 17:10:45 UTC) #3
Roger Tawa OOO till Jul 10th
On 2013/06/27 17:10:45, creis wrote: > On 2013/06/27 13:22:40, Roger Tawa wrote: > > On ...
7 years, 5 months ago (2013-06-27 17:24:00 UTC) #4
Charlie Reis
On 2013/06/27 17:24:00, Roger Tawa wrote: > On 2013/06/27 17:10:45, creis wrote: > > On ...
7 years, 5 months ago (2013-06-27 20:04:46 UTC) #5
Roger Tawa OOO till Jul 10th
lgtm Sounds good Charlie, we can talk about optimization separately.
7 years, 5 months ago (2013-06-27 20:31:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/17962003/1
7 years, 5 months ago (2013-06-27 20:35:32 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 02:50:41 UTC) #8
Message was sent while issue was closed.
Change committed as 209083

Powered by Google App Engine
This is Rietveld 408576698