recipe_modules/raw_io/api.py - Issue 1785543004: Split Placeholder into InputPlaceholder and OutputPlaceholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/raw_io/api.py

Issue 1785543004: Split Placeholder into InputPlaceholder and OutputPlaceholder. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/recipes-py@master

Patch Set: Address comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/raw_io/api.py

diff --git a/recipe_modules/raw_io/api.py b/recipe_modules/raw_io/api.py

index 10da51a8604cde5de76b972ce0119221fd59911b..ea656ceb5d15a82b3c6097243ed86a1b89981fb0 100644

--- a/recipe_modules/raw_io/api.py

+++ b/recipe_modules/raw_io/api.py

@@ -10,7 +10,7 @@ import shutil

import tempfile

-class InputDataPlaceholder(recipe_util.Placeholder):

+class InputDataPlaceholder(recipe_util.InputPlaceholder):

def __init__(self, data, suffix):

assert isinstance(data, basestring)

self.data = data

@@ -42,7 +42,7 @@ class InputDataPlaceholder(recipe_util.Placeholder):

self._backing_file = None

-class OutputDataPlaceholder(recipe_util.Placeholder):

+class OutputDataPlaceholder(recipe_util.OutputPlaceholder):

def __init__(self, suffix, leak_to):

self.suffix = suffix

self.leak_to = leak_to

@@ -80,7 +80,7 @@ class OutputDataPlaceholder(recipe_util.Placeholder):

self._backing_file = None

-class OutputDataDirPlaceholder(recipe_util.Placeholder):

+class OutputDataDirPlaceholder(recipe_util.OutputPlaceholder):

def __init__(self, suffix, leak_to):

self.suffix = suffix

self.leak_to = leak_to

« recipe_engine/util.py ('K') | « recipe_modules/json/api.py ('k') | no next file » | no next file with comments »