recipe_modules/json/api.py - Issue 1785543004: Split Placeholder into InputPlaceholder and OutputPlaceholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/json/api.py

Issue 1785543004: Split Placeholder into InputPlaceholder and OutputPlaceholder. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/recipes-py@master

Patch Set: Address comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/json/api.py

diff --git a/recipe_modules/json/api.py b/recipe_modules/json/api.py

index e65e3135d723d3313bddedc52cb6340efa9f101c..eda76483fb95920380ba7a2e32874744136cf335 100644

--- a/recipe_modules/json/api.py

+++ b/recipe_modules/json/api.py

@@ -12,7 +12,7 @@ from recipe_engine import util as recipe_util

from recipe_engine import config_types

-class JsonOutputPlaceholder(recipe_util.Placeholder):

+class JsonOutputPlaceholder(recipe_util.OutputPlaceholder):

"""JsonOutputPlaceholder is meant to be a placeholder object which, when added

to a step's cmd list, will be replaced by annotated_run with the path to a

temporary file (e.g. /tmp/tmp4lp1qM) which will exist only for the duration of

« recipe_engine/util.py ('K') | « recipe_engine/util.py ('k') | recipe_modules/raw_io/api.py » ('j') | no next file with comments »