Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17848002: Web Inspector: Integrate new regionOversetChange event into inspector (Closed)

Created:
7 years, 6 months ago by stavila
Modified:
7 years, 5 months ago
Reviewers:
Dirk Pranke, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, chromiumbugtracker_adobe.com, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Web Inspector: Integrate new regionOversetChange event into inspector Added the new regionOversetChange event to the WebInspector. BUG=252250 NOTRY=true (unrelated failing tests on win-layout-rel) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153130

Patch Set 1 #

Total comments: 2

Patch Set 2 : Integrated request from pfeldman (made methods private) #

Patch Set 3 : Rebase from master #

Patch Set 4 : Yet another rebase (what were the odds of another conflict in 5 minutes?...) #

Patch Set 5 : Unbelievable… 3 conflicts in 10 minutes #

Patch Set 6 : More rebase... #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -13 lines) Patch
M LayoutTests/inspector/styles/protocol-css-regions-commands.html View 3 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/styles/protocol-css-regions-commands-expected.txt View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 3 chunks +12 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 chunks +72 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/CSSNamedFlowCollectionsView.js View 3 chunks +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 3 chunks +25 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
pfeldman
lgtm with comments. lets extract the sub-agent for regions some time soon - otherwise regions ...
7 years, 6 months ago (2013-06-26 14:37:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/4001
7 years, 6 months ago (2013-06-26 16:02:48 UTC) #2
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2410
7 years, 6 months ago (2013-06-26 16:13:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/11001
7 years, 6 months ago (2013-06-26 16:25:31 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on blink_presubmit HTTP Error 400: Bad Request
7 years, 6 months ago (2013-06-26 16:32:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/10003
7 years, 6 months ago (2013-06-26 16:32:32 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2429
7 years, 6 months ago (2013-06-26 16:40:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/21002
7 years, 6 months ago (2013-06-26 16:43:37 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2434
7 years, 6 months ago (2013-06-26 16:52:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/21002
7 years, 6 months ago (2013-06-26 18:36:13 UTC) #10
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2461
7 years, 6 months ago (2013-06-26 18:58:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/31002
7 years, 6 months ago (2013-06-26 19:18:05 UTC) #12
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2464
7 years, 6 months ago (2013-06-26 19:30:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/31002
7 years, 6 months ago (2013-06-26 20:52:21 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-26 21:15:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/9004
7 years, 6 months ago (2013-06-26 21:18:01 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=11087
7 years, 6 months ago (2013-06-26 23:28:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/9004
7 years, 5 months ago (2013-06-27 05:56:19 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=11122
7 years, 5 months ago (2013-06-27 07:35:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/9004
7 years, 5 months ago (2013-06-27 07:39:10 UTC) #20
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=11140
7 years, 5 months ago (2013-06-27 08:57:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/17848002/9004
7 years, 5 months ago (2013-06-27 09:00:56 UTC) #22
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 09:01:13 UTC) #23
Message was sent while issue was closed. 
Change committed as 153130

Powered by Google App Engine
This is Rietveld 408576698