Commented SSE blend functions and cleaned-up variable naming.

Commented SSE blend functions and cleaned-up variable naming.

Committed: http://code.google.com/p/skia/source/detail?r=9870

[alokp, 2013-06-26 22:42:11]

This is great. Thanks for helping me understand the magic!

LGTM

https://codereview.chromium.org/17847010/diff/1/src/opts/SkBlitRow_opts_SSE2.cpp
File src/opts/SkBlitRow_opts_SSE2.cpp (right):

https://codereview.chromium.org/17847010/diff/1/src/opts/SkBlitRow_opts_SSE2....
src/opts/SkBlitRow_opts_SSE2.cpp:552: // are processed in parallel are marked
with 0, 1, 2, and 3. "d1B", for
IMO positional suffix is not necessary because you already document the full
layout of __m128.

[ernstm, 2013-06-26 23:12:15]

https://codereview.chromium.org/17847010/diff/1/src/opts/SkBlitRow_opts_SSE2.cpp
File src/opts/SkBlitRow_opts_SSE2.cpp (right):

https://codereview.chromium.org/17847010/diff/1/src/opts/SkBlitRow_opts_SSE2....
src/opts/SkBlitRow_opts_SSE2.cpp:552: // are processed in parallel are marked
with 0, 1, 2, and 3. "d1B", for
On 2013/06/26 22:42:11, Alok Priyadarshi wrote:
> IMO positional suffix is not necessary because you already document the full
> layout of __m128.

I had added the positional suffix for the cases where the four pixels are split
into two SSE register, e.g. dstLo and dstHi.

[ernstm, 2013-07-01 23:52:57]

Stephen, can you please do an owner's review for this CL?

[Stephen White, 2013-07-02 16:26:50]

On 2013/07/01 23:52:57, Manfred Ernst wrote:
> Stephen, can you please do an owner's review for this CL?

LGTM, although Ben might want to take a look too (he wrote these, IIRC).

[bungeman-skia, 2013-07-02 16:41:00]

On 2013/07/02 16:26:50, Stephen White wrote:
> On 2013/07/01 23:52:57, Manfred Ernst wrote:
> > Stephen, can you please do an owner's review for this CL?
> 
> LGTM, although Ben might want to take a look too (he wrote these, IIRC).

I just wrote the swizzles (mostly to make this work on Mac, which is BGR, I
think) and added the clamping (to keep things pre-multiplied, we were getting
crazy artifacts on white text). lgtm.

[commit-bot: I haz the power, 2013-07-02 17:21:28]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/ernstm@chromium.org/17847010/6001

[commit-bot: I haz the power, 2013-07-02 17:40:20]

Change committed as 9870