<webview>: Move contentload event from content to chrome

<webview>: Move contentload event from content to chrome

BUG=166165
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209357

[lazyboy, 2013-06-28 18:55:08]

I missed reviewing this one.

https://chromiumcodereview.appspot.com/17846010/diff/4001/chrome/browser/gues...
File chrome/browser/guestview/webview/webview_guest.cc (right):

https://chromiumcodereview.appspot.com/17846010/diff/4001/chrome/browser/gues...
chrome/browser/guestview/webview/webview_guest.cc:83: LoadHandlerCalled();
if (source == guest_web_contents()) {
  LoadHandlerCalled();
}
otherwise DCHECK will be dropped for release build.

https://chromiumcodereview.appspot.com/17846010/diff/4001/chrome/renderer/res...
File chrome/renderer/resources/extensions/web_view.js (right):

https://chromiumcodereview.appspot.com/17846010/diff/4001/chrome/renderer/res...
chrome/renderer/resources/extensions/web_view.js:313:
contentLoadEvent.addListener(function(event) {
We now see a pattern here, so
foo_events = {
  'contentload': contentLoadEvent,
  'loadcommit': loadCommitEvent,
  ...
};

for (a in foo_events) {
  // register event named 'a' with the event foo_events[a]
}

https://chromiumcodereview.appspot.com/17846010/diff/4001/content/renderer/br...
File content/renderer/browser_plugin/browser_plugin.cc (left):

https://chromiumcodereview.appspot.com/17846010/diff/4001/content/renderer/br...
content/renderer/browser_plugin/browser_plugin.cc:588:
TriggerEvent(browser_plugin::kEventContentLoad, NULL);
kEventContent can be removed from browser_plugin_constants?

[Fady Samuel, 2013-06-28 21:24:35]

PTAL.

https://codereview.chromium.org/17846010/diff/4001/chrome/browser/guestview/w...
File chrome/browser/guestview/webview/webview_guest.cc (right):

https://codereview.chromium.org/17846010/diff/4001/chrome/browser/guestview/w...
chrome/browser/guestview/webview/webview_guest.cc:83: LoadHandlerCalled();
On 2013/06/28 18:55:08, lazyboy wrote:
> if (source == guest_web_contents()) {
>   LoadHandlerCalled();
> }
> otherwise DCHECK will be dropped for release build.

Done.

https://codereview.chromium.org/17846010/diff/4001/chrome/renderer/resources/...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/17846010/diff/4001/chrome/renderer/resources/...
chrome/renderer/resources/extensions/web_view.js:313:
contentLoadEvent.addListener(function(event) {
On 2013/06/28 18:55:08, lazyboy wrote:
> We now see a pattern here, so
> foo_events = {
>   'contentload': contentLoadEvent,
>   'loadcommit': loadCommitEvent,
>   ...
> };
> 
> for (a in foo_events) {
>   // register event named 'a' with the event foo_events[a]
> }

Done.

https://codereview.chromium.org/17846010/diff/4001/content/renderer/browser_p...
File content/renderer/browser_plugin/browser_plugin.cc (left):

https://codereview.chromium.org/17846010/diff/4001/content/renderer/browser_p...
content/renderer/browser_plugin/browser_plugin.cc:588:
TriggerEvent(browser_plugin::kEventContentLoad, NULL);
On 2013/06/28 18:55:08, lazyboy wrote:
> kEventContent can be removed from browser_plugin_constants?

Done.

[lazyboy, 2013-06-28 21:29:47]

lgtm

[Fady Samuel, 2013-06-28 23:08:31]

+cdn@ for browser_plugin_messages IPC removal.

[Cris Neckar, 2013-06-28 23:09:37]

rubber stamp lgtm for ipc changes

[commit-bot: I haz the power, 2013-06-29 21:36:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/17846010/26001

[commit-bot: I haz the power, 2013-06-29 23:36:23]

Change committed as 209357