Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 17846010: <webview>: Move contentload event from content to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_loadstop
Patch Set: Merge with ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index ada176048604fcd02e775405ed8baba93bee7135..512f1e4fb870d019da0885cdd0286ca727d9afb1 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -415,10 +415,6 @@ void BrowserPluginGuest::Initialize(
renderer_prefs->browser_handles_all_top_level_requests = false;
notification_registrar_.Add(
- this, NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
- Source<WebContents>(GetWebContents()));
-
- notification_registrar_.Add(
this, NOTIFICATION_RESOURCE_RECEIVED_REDIRECT,
Source<WebContents>(GetWebContents()));
@@ -523,11 +519,6 @@ void BrowserPluginGuest::Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) {
switch (type) {
- case NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME: {
- DCHECK_EQ(Source<WebContents>(source).ptr(), GetWebContents());
- LoadHandlerCalled();
- break;
- }
case NOTIFICATION_RESOURCE_RECEIVED_REDIRECT: {
DCHECK_EQ(Source<WebContents>(source).ptr(), GetWebContents());
ResourceRedirectDetails* resource_redirect_details =
@@ -821,10 +812,6 @@ void BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
embedder_web_contents_->Send(msg);
}
-void BrowserPluginGuest::LoadHandlerCalled() {
- SendMessageToEmbedder(new BrowserPluginMsg_LoadHandlerCalled(instance_id()));
-}
-
void BrowserPluginGuest::DragSourceEndedAt(int client_x, int client_y,
int screen_x, int screen_y, WebKit::WebDragOperation operation) {
web_contents()->GetRenderViewHost()->DragSourceEndedAt(client_x, client_y,
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/common/browser_plugin/browser_plugin_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698