Fix all for-in warnings in dart2js

Fix all for-in warnings in dart2js

NodeList mixes in IterableMixin<Node>. This makes the object bigger,
costing ~3% extra size for the Dart AST. (10MB out of 350MB)
One idea would be to revert this change and make all the for-in sites use
the .nodes member.

Link<T> now implements Iterable<T>, with missing methods added.
IterableMixin could not be used since Link has a const constructor.

I would like to see Link<T> replaced with fixed length lists or
unmodifiable lists.

A couple of other classes were modified to return an Iterable.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/56d0f6aeeec939af69d860a50a0fafdd74a838d6

[sra1, 2016-03-12 00:09:09]

Patchset #1 (id:1) has been deleted

[sra1, 2016-03-12 00:24:27]

Description was changed from

==========
Fix all for-in warnings in dart2js

BUG=
==========

to

==========
Fix all for-in warnings in dart2js

NodeList mixes in IterableMixin<Node>. This makes the object bigger, costing ~3%
extra size for the Dart AST. (10MB out of 350MB)
One idea would be to revert this change and make all the for-in sites use the
.nodes member.

Link<T> now implements Iterable<T>, with missing methods added. IterableMixin
could not be used since Link has a const constructor.

I would like to see Link<T> replaced with fixed length, possibly unmodifiable
lists.

A couple of other classes were modified to return an Iterable.
==========

[sra1, 2016-03-12 00:24:27]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2016-03-12 00:25:52]

Description was changed from

==========
Fix all for-in warnings in dart2js

NodeList mixes in IterableMixin<Node>. This makes the object bigger, costing ~3%
extra size for the Dart AST. (10MB out of 350MB)
One idea would be to revert this change and make all the for-in sites use the
.nodes member.

Link<T> now implements Iterable<T>, with missing methods added. IterableMixin
could not be used since Link has a const constructor.

I would like to see Link<T> replaced with fixed length, possibly unmodifiable
lists.

A couple of other classes were modified to return an Iterable.
==========

to

==========
Fix all for-in warnings in dart2js

NodeList mixes in IterableMixin<Node>. This makes the object bigger,
costing ~3% extra size for the Dart AST. (10MB out of 350MB)
One idea would be to revert this change and make all the for-in sites use
the .nodes member.

Link<T> now implements Iterable<T>, with missing methods added.
IterableMixin could not be used since Link has a const constructor.

I would like to see Link<T> replaced with fixed length lists or
unmodifiable lists.

A couple of other classes were modified to return an Iterable.
==========

[Siggi Cherem (dart-lang), 2016-03-12 00:40:19]

lgtm

https://codereview.chromium.org/1783053005/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1783053005/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/runtime_types.dart:944: for (ClassElement holder
in this.allClassesNeedingTypeChecks) {
=> classes

https://codereview.chromium.org/1783053005/diff/20001/pkg/compiler/lib/src/ut...
File pkg/compiler/lib/src/util/util.dart (right):

https://codereview.chromium.org/1783053005/diff/20001/pkg/compiler/lib/src/ut...
pkg/compiler/lib/src/util/util.dart:9: import 'dart:collection' show
IterableMixin;
drop

[sra1, 2016-03-12 00:44:20]

https://chromiumcodereview.appspot.com/1783053005/diff/20001/pkg/compiler/lib...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://chromiumcodereview.appspot.com/1783053005/diff/20001/pkg/compiler/lib...
pkg/compiler/lib/src/js_backend/runtime_types.dart:944: for (ClassElement holder
in this.allClassesNeedingTypeChecks) {
On 2016/03/12 00:40:19, Siggi Cherem (dart-lang) wrote:
> => classes

Done.

https://chromiumcodereview.appspot.com/1783053005/diff/20001/pkg/compiler/lib...
File pkg/compiler/lib/src/util/util.dart (right):

https://chromiumcodereview.appspot.com/1783053005/diff/20001/pkg/compiler/lib...
pkg/compiler/lib/src/util/util.dart:9: import 'dart:collection' show
IterableMixin;
On 2016/03/12 00:40:19, Siggi Cherem (dart-lang) wrote:
> drop

Done.

[sra1, 2016-03-12 01:19:46]

Description was changed from

==========
Fix all for-in warnings in dart2js

NodeList mixes in IterableMixin<Node>. This makes the object bigger,
costing ~3% extra size for the Dart AST. (10MB out of 350MB)
One idea would be to revert this change and make all the for-in sites use
the .nodes member.

Link<T> now implements Iterable<T>, with missing methods added.
IterableMixin could not be used since Link has a const constructor.

I would like to see Link<T> replaced with fixed length lists or
unmodifiable lists.

A couple of other classes were modified to return an Iterable.
==========

to

==========
Fix all for-in warnings in dart2js

NodeList mixes in IterableMixin<Node>. This makes the object bigger,
costing ~3% extra size for the Dart AST. (10MB out of 350MB)
One idea would be to revert this change and make all the for-in sites use
the .nodes member.

Link<T> now implements Iterable<T>, with missing methods added.
IterableMixin could not be used since Link has a const constructor.

I would like to see Link<T> replaced with fixed length lists or
unmodifiable lists.

A couple of other classes were modified to return an Iterable.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/56d0f6aeeec939af69d860a50a0fafdd74a838d6
==========

[sra1, 2016-03-12 01:19:47]

Committed patchset #2 (id:40001) manually as
56d0f6aeeec939af69d860a50a0fafdd74a838d6 (presubmit successful).