Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4714)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment fixes; more symmetry to logImpression() and logNavigation(). Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index 893b3dfd516477207314525dd4f37b3bd60dab57..baf906ba2d3b05d19328deaa0d5e87982239d992 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -167,6 +167,12 @@ void SearchBox::LogImpression(int position, const base::string16& provider) {
provider));
}
+void SearchBox::LogNavigation(int position, const base::string16& provider) {
samarth 2014/03/06 21:01:22 I think LogMostVisitedClick is clearer here (and i
huangs 2014/03/07 00:33:41 Done, but using LogMostVisitedNavigation() (will c
+ render_view()->Send(new ChromeViewHostMsg_LogNavigation(
+ render_view()->GetRoutingID(), render_view()->GetPageId(), position,
+ provider));
+}
+
void SearchBox::CheckIsUserSignedInToChromeAs(const base::string16& identity) {
render_view()->Send(new ChromeViewHostMsg_ChromeIdentityCheck(
render_view()->GetRoutingID(), render_view()->GetPageId(), identity));
« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698