Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links.

chrome/renderer/searchbox/searchbox.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox.h"
 
 #include <string>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 149 matching lines @@
   render_view()->Send(new ChromeViewHostMsg_LogEvent(
       render_view()->GetRoutingID(), render_view()->GetPageId(), event));
 }
 
 void SearchBox::LogImpression(int position, const base::string16& provider) {
   render_view()->Send(new ChromeViewHostMsg_LogImpression(
       render_view()->GetRoutingID(), render_view()->GetPageId(), position,
       provider));
 }
 
+void SearchBox::LogNavigation(int position, const base::string16& provider) {

[samarth, 2014/03/06 21:01:22]

I think LogMostVisitedClick is clearer here (and in SearchIPCRoucter, etc).

Can you also rename LogImpression to LogMostVistedImpression to match while
you're at it?

[huangs, 2014/03/07 00:33:41]

Done, but using LogMostVisitedNavigation() (will change if you insist).

+  render_view()->Send(new ChromeViewHostMsg_LogNavigation(
+      render_view()->GetRoutingID(), render_view()->GetPageId(), position,
+      provider));
+}
+
 void SearchBox::CheckIsUserSignedInToChromeAs(const base::string16& identity) {
   render_view()->Send(new ChromeViewHostMsg_ChromeIdentityCheck(
       render_view()->GetRoutingID(), render_view()->GetPageId(), identity));
 }
 
 void SearchBox::DeleteMostVisitedItem(
     InstantRestrictedID most_visited_item_id) {
   render_view()->Send(new ChromeViewHostMsg_SearchBoxDeleteMostVisitedItem(
       render_view()->GetRoutingID(), render_view()->GetPageId(),
       GetURLForMostVisitedItem(most_visited_item_id)));
@@ skipping 273 matching lines @@
 }
 
 void SearchBox::Reset() {
   query_.clear();
   suggestion_ = InstantSuggestion();
   start_margin_ = 0;
   is_focused_ = false;
   is_key_capture_enabled_ = false;
   theme_info_ = ThemeBackgroundInfo();
 }