Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 17746004: [Android] Add bot id for an x86 fyi and try builders (Closed)

Created:
7 years, 6 months ago by Siva Chandra
Modified:
7 years, 5 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Add bot id for an x86 fyi and try builders BUG=170542 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211202

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove zip_build step #

Patch Set 3 : Add bot-id for x86 fyi builder #

Total comments: 6

Patch Set 4 : Address comments #

Total comments: 1

Patch Set 5 : Last nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M build/android/buildbot/bb_run_bot.py View 1 2 3 4 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Siva Chandra
7 years, 6 months ago (2013-06-25 21:22:54 UTC) #1
Isaac (away)
lgtm
7 years, 5 months ago (2013-06-27 10:17:21 UTC) #2
Isaac (away)
https://codereview.chromium.org/17746004/diff/1/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://codereview.chromium.org/17746004/diff/1/build/android/buildbot/bb_run_bot.py#newcode135 build/android/buildbot/bb_run_bot.py:135: H(std_build_steps + std_host_tests, target_arch='x86')), See comments in other CL ...
7 years, 5 months ago (2013-06-27 10:21:59 UTC) #3
Siva Chandra
PTaL https://chromiumcodereview.appspot.com/17746004/diff/1/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://chromiumcodereview.appspot.com/17746004/diff/1/build/android/buildbot/bb_run_bot.py#newcode135 build/android/buildbot/bb_run_bot.py:135: H(std_build_steps + std_host_tests, target_arch='x86')), On 2013/06/27 10:21:59, Isaac ...
7 years, 5 months ago (2013-06-27 18:53:17 UTC) #4
Isaac (away)
lgtm
7 years, 5 months ago (2013-06-28 02:27:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/17746004/6001
7 years, 5 months ago (2013-06-28 18:36:46 UTC) #6
Siva Chandra
On 2013/06/28 02:27:00, Isaac wrote: > lgtm You probably want to take another look as ...
7 years, 5 months ago (2013-07-02 21:47:30 UTC) #7
Isaac (away)
https://chromiumcodereview.appspot.com/17746004/diff/31001/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://chromiumcodereview.appspot.com/17746004/diff/31001/build/android/buildbot/bb_run_bot.py#newcode116 build/android/buildbot/bb_run_bot.py:116: fyi_test_args = ['--experimental', flakiness_server] too many vars, remove 116 ...
7 years, 5 months ago (2013-07-03 09:02:28 UTC) #8
Siva Chandra
PTaL at patch set 4. Addressed all previous comments. https://chromiumcodereview.appspot.com/17746004/diff/31001/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://chromiumcodereview.appspot.com/17746004/diff/31001/build/android/buildbot/bb_run_bot.py#newcode116 build/android/buildbot/bb_run_bot.py:116: ...
7 years, 5 months ago (2013-07-09 20:47:55 UTC) #9
Siva Chandra
ping?
7 years, 5 months ago (2013-07-11 01:26:13 UTC) #10
Isaac (away)
still looks good to me.. https://chromiumcodereview.appspot.com/17746004/diff/37001/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://chromiumcodereview.appspot.com/17746004/diff/37001/build/android/buildbot/bb_run_bot.py#newcode115 build/android/buildbot/bb_run_bot.py:115: fyi_host_args = ['--experimental'] experimental ...
7 years, 5 months ago (2013-07-11 02:20:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/17746004/44001
7 years, 5 months ago (2013-07-11 18:42:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/17746004/44001
7 years, 5 months ago (2013-07-11 20:23:21 UTC) #13
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 20:23:43 UTC) #14
Message was sent while issue was closed.
Change committed as 211202

Powered by Google App Engine
This is Rietveld 408576698