[Android] Add bot id for an x86 fyi and try builders

build/android/buildbot/bb_run_bot.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import copy
 import json
 import os
@@ skipping 27 matching lines @@
       diff.append('+ %s=%s' % (key, pipes.quote(d2[key])))
   return '\n'.join(diff)
 
 
 def GetEnvironment(host_obj, testing):
   init_env = dict(os.environ)
   init_env['GYP_GENERATORS'] = 'ninja'
   init_env['GOMA_DIR'] = bb_utils.GOMA_DIR
   envsetup_cmd = '. build/android/envsetup.sh'
   if host_obj.target_arch:
-    envsetup_cmd += ' --target_arch=%s' % host_obj.target_arch
+    envsetup_cmd += ' --target-arch=%s' % host_obj.target_arch
   if testing:
     # Skip envsetup to avoid presubmit dependence on android deps.
     print 'Testing mode - skipping "%s"' % envsetup_cmd
     envsetup_cmd = ':'
   else:
     print 'Running %s' % envsetup_cmd
   proc = subprocess.Popen(['bash', '-exc',
     envsetup_cmd + ' >&2; python build/android/buildbot/env_to_json.py'],
     stdout=subprocess.PIPE, stderr=subprocess.PIPE,
     cwd=bb_utils.CHROME_SRC, env=init_env)
@@ skipping 46 matching lines @@
   return commands
 
 
 def GetBotStepMap():
   compile_step = ['compile']
   std_host_tests = ['check_webview_licenses', 'findbugs']
   std_build_steps = ['compile', 'zip_build']
   std_test_steps = ['extract_build']
   std_tests = ['ui', 'unit']
   flakiness_server = '--upload-to-flakiness-server'
+  fyi_host_args = ['--experimental']
+  fyi_test_args = ['--experimental', flakiness_server]

[Isaac (away), 2013/07/03 09:02:28]

too many vars, remove 116

[Siva Chandra, 2013/07/09 20:47:55]

Done.

 
   B = BotConfig
   H = (lambda steps, extra_args=None, extra_gyp=None, target_arch=None :
        HostConfig('build/android/buildbot/bb_host_steps.py', steps, extra_args,
                   extra_gyp, target_arch))
   T = (lambda tests, extra_args=None :
        TestConfig('build/android/buildbot/bb_device_steps.py', tests,
                   extra_args))
 
   bot_configs = [
       # Main builders
       B('main-builder-dbg', H(std_build_steps + std_host_tests)),
       B('main-builder-rel', H(std_build_steps)),
       B('main-clang-builder',
         H(compile_step, extra_gyp='clang=1 component=shared_library')),
       B('main-clobber', H(compile_step)),
       B('main-tests', H(std_test_steps), T(std_tests, [flakiness_server])),
 
       # Other waterfalls
       B('asan-builder-tests', H(compile_step, extra_gyp='asan=1'),
         T(std_tests, ['--asan'])),
       B('chromedriver-fyi-tests-dbg', H(std_test_steps),
         T(['chromedriver'], ['--install=ChromiumTestShell'])),
+      B('fyi-x86-builder-dbg',
+        H(compile_step + std_host_tests, fyi_host_args, target_arch='x86')),
       B('fyi-builder-dbg',
-        H(std_build_steps + std_host_tests, ['--experimental'])),
-      B('fyi-builder-rel', H(std_build_steps,  ['--experimental'])),
-      B('fyi-tests-dbg-ics-gn', H(compile_step, [ '--experimental']),
-        T(std_tests, ['--experimental', flakiness_server])),
-      B('fyi-tests', H(std_test_steps),
-        T(std_tests, ['--experimental', flakiness_server])),
+        H(std_build_steps + std_host_tests, fyi_host_args)),
+      B('fyi-builder-rel', H(std_build_steps,  fyi_host_args)),
+      B('fyi-tests-dbg-ics-gn', H(compile_step, fyi_host_args),

[Isaac (away), 2013/07/03 09:02:28]

please remove fyi-tests-dbg-ics-gn config.

[Siva Chandra, 2013/07/09 20:47:55]

Done.

+        T(std_tests, fyi_test_args)),
+      B('fyi-tests', H(std_test_steps), T(std_tests, fyi_test_args)),
       B('fyi-component-builder-tests-dbg',
         H(compile_step, extra_gyp='component=shared_library'),
-        T(std_tests, ['--experimental', flakiness_server])),
+        T(std_tests, fyi_test_args)),
       B('perf-bisect-builder-tests-dbg', H(['bisect_perf_regression'])),
       B('perf-tests-rel', H(std_test_steps),
         T([], ['--install=ChromiumTestShell'])),
+      B('try-x86-builder-dbg',

[Isaac (away), 2013/07/03 09:02:28]

Please follow the same pattern as other trybot configs.

[Siva Chandra, 2013/07/09 20:47:55]

Done.

+        H(compile_step + std_host_tests, target_arch='x86')),
       B('webkit-latest-webkit-tests', H(std_test_steps),
         T(['webkit_layout', 'webkit'])),
       B('webkit-latest-contentshell', H(compile_step), T(['webkit_layout'])),
       B('builder-unit-tests', H(compile_step), T(['unit'])),
 
       # Generic builder config (for substring match).
       B('builder', H(std_build_steps)),
   ]
 
   bot_map = dict((config.bot_id, config) for config in bot_configs)
@@ skipping 82 matching lines @@
     sys.stdout.flush()
     if options.testing:
       env['BUILDBOT_TESTING'] = '1'
     return_code = subprocess.call(command, cwd=bb_utils.CHROME_SRC, env=env)
     if return_code != 0:
       return return_code
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))