Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 17738004: Apply cross-origin auth prompt blocking to image resources only. (Closed)

Created:
7 years, 6 months ago by Tom Sepez
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Apply cross-origin auth prompt blocking to image resources only. This CL applies both cross-origin basic auth prompt blocking, and the stripping of embedded URL identities to image src URLs only. See the bug for a description of why we think this is acceptable. The first part of the change is to rename HttpAuthResourceType to HttpAuthRelationType, to avoid confusion with ResourceType since both are now used closely together. Then, BuildLoadFlagsForRequest() is made a method, rather than just a function, so it can access information needed to compute the relation type. It blocks the sending of credentials as well as the popping of popups for images under the right conditions. BUG=174179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209100

Patch Set 1 #

Patch Set 2 : Make Relation Type private once again. #

Patch Set 3 : Pass correct flag for no auth, not no prompt. #

Patch Set 4 : Add prompt test cases. #

Patch Set 5 : Fix hostname in test. #

Patch Set 6 : Even simpler implementation using load flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -78 lines) Patch
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 2 3 4 2 chunks +50 lines, -3 lines 0 comments Download
A chrome/test/data/login/load_iframe_from_b.html View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 2 chunks +12 lines, -7 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 5 4 chunks +68 lines, -68 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Sepez
Please review: @simonjam - content/browser/loader/* @ben - chrome/browser/ui/*
7 years, 6 months ago (2013-06-26 17:26:38 UTC) #1
James Simonsen
lgtm
7 years, 6 months ago (2013-06-26 18:07:47 UTC) #2
Tom Sepez
Sky, can I get an owner's review for login_prompt_browsertest.cc? Thanks.
7 years, 5 months ago (2013-06-27 18:42:12 UTC) #3
sky
LGTM
7 years, 5 months ago (2013-06-27 19:45:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/17738004/18001
7 years, 5 months ago (2013-06-27 19:54:02 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 05:27:21 UTC) #6
Message was sent while issue was closed.
Change committed as 209100

Powered by Google App Engine
This is Rietveld 408576698