|
|
Chromium Code Reviews|
Created:
7 years, 6 months ago by Owen Lin Modified:
7 years, 5 months ago CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionReturns empty dict for GetIOStats on CrOS platforms.
BUG=252912
TEST=Manully test the code on link
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209177
Patch Set 1 #Patch Set 2 : rebase and add notry #Patch Set 3 : rebase #Patch Set 4 : try again #
Messages
Total messages: 20 (0 generated)
PTAL. Thanks.
On 2013/06/24 07:05:54, Owen Lin wrote: > PTAL. Thanks. lgtm, thanks!
Do we have a bug filed about not having IO stats on CrOS? That seems like somethign worth having.
On 2013/06/24 17:09:10, nduca wrote: > Do we have a bug filed about not having IO stats on CrOS? That seems like > somethign worth having. I just created one [http://crbug.com/253786] and assigned to Tony.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/1
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/1
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/1
Failed to apply patch for
tools/telemetry/docs/telemetry.page.page_test_runner.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file tools/telemetry/docs/telemetry.page.page_test_runner.html
Hunk #1 FAILED at 100.
1 out of 1 hunk FAILED -- saving rejects to file
tools/telemetry/docs/telemetry.page.page_test_runner.html.rej
Patch: tools/telemetry/docs/telemetry.page.page_test_runner.html
Index: tools/telemetry/docs/telemetry.page.page_test_runner.html
diff --git a/tools/telemetry/docs/telemetry.page.page_test_runner.html
b/tools/telemetry/docs/telemetry.page.page_test_runner.html
index
4acbb00af4b0883fe109c1f08198280b12e4ccb1..6856c9bf6a1a2155965c955db8ef9ac7902565b3
100644
--- a/tools/telemetry/docs/telemetry.page.page_test_runner.html
+++ b/tools/telemetry/docs/telemetry.page.page_test_runner.html
@@ -100,12 +100,5 @@ Data descriptors defined here:<br>
<br>
Args:<br>
base_dir: Path to directory containing tests and ProfileCreators.</tt></dd></dl>
-</td></tr></table><p>
-<table width="100%" cellspacing=0 cellpadding=2 border=0 summary="section">
-<tr bgcolor="#55aa55">
-<td colspan=3 valign=bottom> <br>
-<font color="#ffffff" face="helvetica,
arial"><big><strong>Data</strong></big></font></td></tr>
-
-<tr><td
bgcolor="#55aa55"><tt> </tt></td><td> </td>
-<td width="100%"><strong>__warningregistry__</strong> = {("Not importing
directory '/usr/local/google/code/...ls/telemetry/telemetry/test': missing
__init__.py", <type 'exceptions.ImportWarning'>, 7):
True}</td></tr></table>
+</td></tr></table>
</body></html>
\ No newline at end of file
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/17001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/24001
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/19002
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
On 2013/06/28 04:38:07, I haz the power (commit-bot) wrote: > Retried try job too often on chromium_presubmit for step(s) presubmit > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p... You are going to have to NOTRY=True this patch. It looks like there is a bug in the presubmit. I'll file it.
Thank you so much. :) Actually, I did try to add the NOTRY entry in the commit. But I did that in a local git commit (and then upload it). On Fri, Jun 28, 2013 at 12:39 PM, <tonyg@chromium.org> wrote: > On 2013/06/28 04:38:07, I haz the power (commit-bot) wrote: >> >> Retried try job too often on chromium_presubmit for step(s) presubmit > > > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p... > > You are going to have to NOTRY=True this patch. It looks like there is a bug > in > the presubmit. I'll file it. > > https://chromiumcodereview.appspot.com/17591003/ -- Owen Cheng-Ru Lin Google Taipei Software Engineer
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/19002
Message was sent while issue was closed.
Change committed as 209177 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
