Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 17591003: Returns empty dict for GetIOStats on CrOS platforms. (Closed)

Created:
7 years, 6 months ago by Owen Lin
Modified:
7 years, 5 months ago
Reviewers:
owenlin_google, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Returns empty dict for GetIOStats on CrOS platforms. BUG=252912 TEST=Manully test the code on link NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209177

Patch Set 1 #

Patch Set 2 : rebase and add notry #

Patch Set 3 : rebase #

Patch Set 4 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/telemetry/docs/telemetry.core.platform.cros_platform_backend.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_platform_backend.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Owen Lin
PTAL. Thanks.
7 years, 6 months ago (2013-06-24 07:05:54 UTC) #1
tonyg
On 2013/06/24 07:05:54, Owen Lin wrote: > PTAL. Thanks. lgtm, thanks!
7 years, 6 months ago (2013-06-24 15:39:19 UTC) #2
nduca
Do we have a bug filed about not having IO stats on CrOS? That seems ...
7 years, 6 months ago (2013-06-24 17:09:10 UTC) #3
Owen Lin
On 2013/06/24 17:09:10, nduca wrote: > Do we have a bug filed about not having ...
7 years, 6 months ago (2013-06-25 02:39:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/1
7 years, 6 months ago (2013-06-25 02:41:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=12045
7 years, 6 months ago (2013-06-25 02:56:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/1
7 years, 6 months ago (2013-06-25 07:20:49 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=12076
7 years, 6 months ago (2013-06-25 07:38:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/1
7 years, 5 months ago (2013-06-28 02:45:34 UTC) #9
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/docs/telemetry.page.page_test_runner.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-06-28 02:45:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/17001
7 years, 5 months ago (2013-06-28 03:01:35 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=12903
7 years, 5 months ago (2013-06-28 03:15:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/24001
7 years, 5 months ago (2013-06-28 03:44:37 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=12908
7 years, 5 months ago (2013-06-28 03:54:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/19002
7 years, 5 months ago (2013-06-28 04:19:52 UTC) #15
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=12913
7 years, 5 months ago (2013-06-28 04:38:07 UTC) #16
tonyg
On 2013/06/28 04:38:07, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 5 months ago (2013-06-28 04:39:17 UTC) #17
owenlin_google
Thank you so much. :) Actually, I did try to add the NOTRY entry in ...
7 years, 5 months ago (2013-06-28 06:00:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/17591003/19002
7 years, 5 months ago (2013-06-28 06:00:24 UTC) #19
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 17:46:34 UTC) #20
Message was sent while issue was closed.
Change committed as 209177

Powered by Google App Engine
This is Rietveld 408576698