Issue 17589004: FakeDriveService::DeleteResource should keep deleted entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17589004: FakeDriveService::DeleteResource should keep deleted entry. (Closed)

Created:
7 years, 6 months ago by tzik

Modified:
7 years, 6 months ago

Reviewers:
kinaba

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

FakeDriveService::DeleteResource should keep deleted entry. * Keep deleted resource with deleted flag and return the resource in the change list. * Don't include the deleted resource in the search result nor listing result of a directory. BUG=232208 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208399

Patch Set 1 #

Patch Set 2 : listing deleted resources #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -5 lines)			Patch
	M	chrome/browser/drive/fake_drive_service.cc	View	1	3 chunks	+15 lines, -4 lines	0 comments	Download
	M	chrome/browser/drive/fake_drive_service_unittest.cc	View	1	4 chunks	+71 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/17589004/2001

7 years, 6 months ago (2013-06-25 02:27:58 UTC) #3

Message was sent while issue was closed.

Change committed as 208399

Expand Messages | Collapse Messages