Set Attr.ownerDocument in Element#setAttributeNode()

Set Attr.ownerDocument in Element#setAttributeNode()

Attr objects can move across documents by setAttributeNode().
So It needs to reset ownerDocument through TreeScopeAdoptr::adoptIfNeeded().

BUG=248950
TEST=set-attribute-node-from-iframe.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152938

[Hajime Morrita, 2013-06-24 02:59:53]

Could you review this one-line fix? This is caught by the fuzzer.

[tkent, 2013-06-24 05:06:37]

lgtm

https://codereview.chromium.org/17583003/diff/1/LayoutTests/fast/dom/Attr/set...
File LayoutTests/fast/dom/Attr/set-attribute-node-from-iframe.html (right):

https://codereview.chromium.org/17583003/diff/1/LayoutTests/fast/dom/Attr/set...
LayoutTests/fast/dom/Attr/set-attribute-node-from-iframe.html:10:
description("ownerNode of Attr should be set on setAttributeNode");
ownerNode -> ownerDocument

https://codereview.chromium.org/17583003/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/17583003/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:1812: treeScope()->adoptIfNeeded(attrNode);
This is ok. However, should it be in Attr::attachToElement?

[Hajime Morrita, 2013-06-24 05:24:09]

Kent-san, thanks for  reviewing!

https://codereview.chromium.org/17583003/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/17583003/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:1812: treeScope()->adoptIfNeeded(attrNode);
On 2013/06/24 05:06:37, tkent wrote:
> This is ok. However, should it be in Attr::attachToElement?
I thought like that, but turned out that another adoptIfNeeded() call to an Attr
object is done in Element.cpp as well.
So I changed my mind in this way.

[tkent, 2013-06-24 05:26:30]

https://codereview.chromium.org/17583003/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/17583003/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:1812: treeScope()->adoptIfNeeded(attrNode);
On 2013/06/24 05:24:09, morrita1 wrote:
> On 2013/06/24 05:06:37, tkent wrote:
> > This is ok. However, should it be in Attr::attachToElement?
> I thought like that, but turned out that another adoptIfNeeded() call to an
Attr
> object is done in Element.cpp as well.
> So I changed my mind in this way.

It makes sense.

[commit-bot: I haz the power, 2013-06-24 05:26:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/17583003/5002

[commit-bot: I haz the power, 2013-06-24 06:50:04]

Change committed as 152938