Source/core/dom/Element.cpp - Issue 17583003: Set Attr.ownerDocument in Element#setAttributeNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 17583003: Set Attr.ownerDocument in Element#setAttributeNode() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed the point. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 941c660a172350af91c10c8e51d2f704c79794d4..5f0e0f66fd2929ef2562836ef10785be0b94c6d3 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -1809,6 +1809,7 @@ PassRefPtr<Attr> Element::setAttributeNode(Attr* attrNode, ExceptionCode& ec)

setAttributeInternal(index, attrNode->qualifiedName(), attrNode->value(), NotInSynchronizationOfLazyAttribute);

attrNode->attachToElement(this);

+ treeScope()->adoptIfNeeded(attrNode);

ensureAttrNodeListForElement(this)->append(attrNode);

return oldAttrNode.release();

« no previous file with comments | « LayoutTests/fast/dom/Attr/set-attribute-node-from-iframe-expected.txt ('k') | no next file » | no next file with comments »