Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 17572008: WIP IDL compiler rewrite (Closed)

Created:
7 years, 6 months ago by kojih
Modified:
6 years, 9 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, do-not-use, kouhei (in TOK)
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

WIP IDL compiler rewrite (Closed as instead rewritten incrementally, and bug now closed.) BUG=239771

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : most of non-callback headers #

Patch Set 4 : non-callback headers working #

Patch Set 5 : non-callback h except SVG is OK(444 files) #

Patch Set 6 : 504 / 1312 #

Patch Set 7 : 528/1312 #

Patch Set 8 : 562 / 1312 #

Patch Set 9 : 571 / 1312 #

Patch Set 10 : 604 / 1312 #

Patch Set 11 : 630 / 1312 #

Patch Set 12 : 644 / 1306 #

Patch Set 13 : 648 / 1306 #

Patch Set 14 : 672 / 1302 (basic function and its callback) #

Patch Set 15 : 685 / 1302 basic constants #

Patch Set 16 : 695 / 1302 #

Patch Set 17 : 710 / 1302 #

Patch Set 18 : 754 / 1002 #

Patch Set 19 : 754 / 1002 ... except SVG (about 300) files #

Patch Set 20 : 770 / 1002 #

Patch Set 21 : 778 / 1002 ... move common template into macro. implemented CallWith #

Patch Set 22 : 838 / 1320 #

Patch Set 23 : 794 / 1320 lots of IDLs changed in master :( #

Patch Set 24 : 860 / 1320 remain: 460 #

Patch Set 25 : 905 / 1320 remain: 415 #

Patch Set 26 : 1112 / 1324 remain: 212 #

Patch Set 27 : 1123 / 1324 remain: 201 #

Patch Set 28 : 1243 / 1324 (81 remain) #

Patch Set 29 : 1242 / 1326 (84 remain) #

Patch Set 30 : 1182 / 1326 (144 remain), (not merged from master) #

Patch Set 31 : Cleanup (partial) #

Patch Set 32 : Cleanup #

Patch Set 33 : Refactoring #

Patch Set 34 : Major Refactoring #

Patch Set 35 : Ready for branching! #

Patch Set 36 : Branch: const + primitive type readonly attributes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5786 lines, -413 lines) Patch
M Source/bindings/derived_sources.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 6 chunks +119 lines, -98 lines 0 comments Download
A Source/bindings/scripts/code_generator_idl_reader.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 1 chunk +163 lines, -0 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 6 chunks +140 lines, -245 lines 0 comments Download
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 142 chunks +330 lines, -13 lines 0 comments Download
M Source/bindings/scripts/idl_compiler.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 2 chunks +15 lines, -10 lines 0 comments Download
A Source/bindings/scripts/v8_attributes.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +618 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_constructors.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +162 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_functions.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +421 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_includes.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +131 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_interface.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +286 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_interface_header.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +186 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_special_accessors.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 1 chunk +360 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_types.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +534 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_utilities.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +243 lines, -0 lines 0 comments Download
A Source/bindings/scripts/v8_values.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +366 lines, -0 lines 0 comments Download
A Source/bindings/templates/attributes.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +45 lines, -0 lines 0 comments Download
A Source/bindings/templates/attributes_wip.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +257 lines, -0 lines 0 comments Download
M Source/bindings/templates/callback_interface.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 5 chunks +26 lines, -1 line 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 5 chunks +31 lines, -4 lines 0 comments Download
A Source/bindings/templates/constants.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 1 chunk +52 lines, -0 lines 0 comments Download
A Source/bindings/templates/constructors.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +189 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 5 chunks +4 lines, -8 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 6 chunks +26 lines, -34 lines 0 comments Download
A Source/bindings/templates/interface_wip.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +258 lines, -0 lines 0 comments Download
A Source/bindings/templates/interface_wip.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +526 lines, -0 lines 0 comments Download
A Source/bindings/templates/macros.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 1 chunk +298 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kojih
Issue: https://code.google.com/p/chromium/issues/detail?id=239771
7 years, 6 months ago (2013-06-24 10:49:10 UTC) #1
haraken
I realized that the template makes the code generation much much cleaner. Once the Python ...
7 years, 6 months ago (2013-06-24 11:03:51 UTC) #2
Nils Barth (inactive)
Posted latest WIP, which has lots of cleanup and refactoring. It still needs a *lot* ...
7 years, 4 months ago (2013-08-16 10:17:51 UTC) #3
haraken
On 2013/08/16 10:17:51, Nils Barth wrote: > Posted latest WIP, which has lots of cleanup ...
7 years, 4 months ago (2013-08-16 13:00:02 UTC) #4
Nils Barth (inactive)
Here's another update. This splits off constants, both in the code generator and in the ...
7 years, 4 months ago (2013-08-16 14:40:57 UTC) #5
Nils Barth (inactive)
Here's an update. It's now refactored sufficiently that branching is easy: the current code (well, ...
7 years, 4 months ago (2013-08-21 01:24:37 UTC) #6
Nils Barth (inactive)
7 years, 4 months ago (2013-08-21 04:31:34 UTC) #7
Latest patch set has consts + primitive type readonly attributes as a distinct
branch;
(need to add some attributes to get new passing IDL files).

I'll now post a separate const CL by just cutting along the line!

Powered by Google App Engine
This is Rietveld 408576698