Issue 17553018: Initial stream support

Issue 17553018: Initial stream support (Closed)

Created:
7 years, 6 months ago by justinfagnani

Modified:
7 years, 6 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/fancy-syntax.git@master

Visibility:
Public.

More Reviews

Patch Set 2 : address review comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -27 lines)			Patch
M	example/example.html	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
A	example/streams/collect_key_press.html	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	example/streams/count_clicks.html	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	example/streams/mouse_move.html	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
A	example/streams/mouse_resize_image.html	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	lib/async.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	lib/eval.dart	View		7 chunks	+40 lines, -14 lines	0 comments	Download
A	lib/src/mirrors.dart	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	lib/syntax.dart	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/all_tests.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/eval_tests.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/collect_key_press.html File example/streams/collect_key_press.html (right): https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/collect_key_press.html#newcode3 example/streams/collect_key_press.html:3: Copyright (c) 2012, the Dart project authors. Please ...

7 years, 6 months ago (2013-06-24 18:30:35 UTC) #2

justinfagnani

7 years, 6 months ago (2013-06-25 03:45:36 UTC) #3

thanks!

https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/col...
File example/streams/collect_key_press.html (right):

https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/col...
example/streams/collect_key_press.html:3: Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
On 2013/06/24 18:30:35, John Messerly wrote:
> 2013, here and in other files

Done.

https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/col...
example/streams/collect_key_press.html:28: 'keyPress':
document.onKeyPress.map((e) => new String.fromCharCode(e.charCode)),
On 2013/06/24 18:30:35, John Messerly wrote:
> long line

Done.

https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/cou...
File example/streams/count_clicks.html (right):

https://chromiumcodereview.appspot.com/17553018/diff/2001/example/streams/cou...
example/streams/count_clicks.html:14: import 'dart:async';
On 2013/06/24 18:30:35, John Messerly wrote:
> style question, should this be left justified?

no idea :) it looks better to me this way.

https://chromiumcodereview.appspot.com/17553018/diff/2001/lib/src/mirrors.dart
File lib/src/mirrors.dart (right):

https://chromiumcodereview.appspot.com/17553018/diff/2001/lib/src/mirrors.dar...
lib/src/mirrors.dart:41: && (superclass.qualifiedName != new
Symbol("dart.core.Object"));
On 2013/06/24 18:30:35, John Messerly wrote:
> perhaps:
> 
> var obj = reflectClass(Object);
> return superclass != null && superclass != obj;

Done.

Expand Messages | Collapse Messages