Issue 17515005: Do not put v1 app windows or popup windows into immersive fullscreen

Issue 17515005: Do not put v1 app windows or popup windows into immersive fullscreen (Closed)

Created:
7 years, 6 months ago by pkotwicz

Modified:
7 years, 6 months ago

Reviewers:
James Cook

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, tfarina, mazda+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This CL does the following - puts browser windows which would have used AppNonClientFrameViewAsh into maximized mode - puts v1 app windows which would not have used AppNonClientFrameViewAsh and browser popup windows into tab fullscreen - Makes Alt+ put windows into maximized mode. (That's what Ctrl+Alt+? indicates) TEST=ChromeShellDelegateBrowserTest BUG=251311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207910

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Removed maximize behavior for task manager to be consistent with how F11 works on other platforms #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -37 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View	1 2 3	2 chunks	+21 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc	View	1 2 3	3 chunks	+144 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2	5 chunks	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM with nits https://codereview.chromium.org/17515005/diff/28002/chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc File chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc (right): https://codereview.chromium.org/17515005/diff/28002/chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc#newcode101 chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc:101: // TODO(linux aura) http://crbug.com/163931 nit: indent ...

7 years, 6 months ago (2013-06-21 00:50:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/17515005/48001

7 years, 6 months ago (2013-06-21 16:36:36 UTC) #3

Message was sent while issue was closed.

Change committed as 207910

Expand Messages | Collapse Messages