chrome/browser/ui/views/frame/browser_view.h - Issue 17515005: Do not put v1 app windows or popup windows into immersive fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 17515005: Do not put v1 app windows or popup windows into immersive fullscreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed maximize behavior for task manager to be consistent with how F11 works on other platforms Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index bac93d8c2688dad310200787976f0d600bcd6858..5d6d955c27fb7d2084d49a54ddef6366ad000d65 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -551,6 +551,11 @@ class BrowserView : public BrowserWindow,

const GURL& url,

FullscreenExitBubbleType bubble_type);

+ // Returns whether immmersive fullscreen should replace fullscreen. This

+ // should only occur for "browser-fullscreen" for tabbed-typed windows (not

+ // for tab-fullscreen and not for app/popup type windows).

+ bool ShouldUseImmersiveFullscreenForUrl(const GURL& url) const;

// Copy the accelerator table from the app resources into something we can

// use.

void LoadAccelerators();