Move DataElement into webkit/common

Move DataElement into webkit/common

R=michaeln
BUG=237267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211006

[jamesr, 2013-06-20 20:43:52]

Michael - please review
Cris - there's a namespace in change in resource_message.cc/h, could you
approve?

[darin (slow to review), 2013-06-20 21:02:03]

On 2013/06/20 20:43:52, jamesr wrote:
> Michael - please review
> Cris - there's a namespace in change in resource_message.cc/h, could you
> approve?

Note, there's going to be a merge conflict with:
https://codereview.chromium.org/16831010

That one is in the CQ.

[darin (slow to review), 2013-06-20 21:28:30]

On 2013/06/20 21:02:03, darin wrote:
...
> Note, there's going to be a merge conflict with:
> https://codereview.chromium.org/16831010
> 
> That one is in the CQ.

^^^ And it failed.  You should go first.  It'll actually simplify that other CL.

[darin (slow to review), 2013-06-20 21:29:12]

LGTM

[Cris Neckar, 2013-06-20 21:31:56]

rubberstamp LGTM for ipc changes

[commit-bot: I haz the power, 2013-06-20 21:35:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17513002/1

[michaeln, 2013-06-20 21:46:25]

lgtm2

[commit-bot: I haz the power, 2013-06-20 22:10:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jamesr, 2013-06-20 22:44:46]

It looks like clang died because webkit_storage_common uses DataElement but
doesn't have a declared dependency on webkit_common.  Unfortunately adding a
dependency there is problematic since the webkit_common target is in a gypi
that's included into webkit_support.gyp, but webkit_storage_common is a
standalone gyp.  Since targets in webkit_storage.gyp depend on
webkit_storage_common, wk_s_c can't declare a dependency on anything in
webkit_storage.gyp without creating a gyp cycle with the xcode generator
explodes on.  The fix is to pull webkit_common out into its own .gyp file, but
webkit_common depends on webkit_resources which is defined in a different gypi
also inside webkit_storage.gyp, so I have to pull that out first.  Yuck!  I'll
do the wk_resource bit as a separate patch since it's only very tangentially
related to this one.

gypis are hell!

[jamesr, 2013-06-20 22:47:42]

Oh bollocks, webkit_resources is referenced from DumpRenderTree.gyp in the Blink
repository, so it's a 3-sided patch to move it.

[jamesr, 2013-07-10 22:48:49]

The resources issue has been sorted out with a 5-way patch.  Thanks to other
patches, this patch now completely removes webkit/base/.

[commit-bot: I haz the power, 2013-07-10 22:49:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/17513002/26001

[commit-bot: I haz the power, 2013-07-11 01:46:21]

Change committed as 211006