Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17480002: Remove unused includes from core/accessibility, core/css and core/dom (Closed)

Created:
7 years, 6 months ago by Timothy Loh
Modified:
7 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, kenneth.christiansen, chromiumbugtracker_adobe.com, aboxhall, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dominicc+watchlist_chromium.org, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unused includes from core/accessibility, core/css and core/dom Continue removing unused includes as suggested by include-what-you-use. I've manually looked through all the changes so all the removals should be actually unused. As usual, if a .cpp only needs a fwd decl of a type used in a method signature, I assume that the header would already have included or declared the type and remove the include from the .cpp. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152858

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 4

Patch Set 3 : rebased ; update <wtf/Foo.h> to "wtf/Foo.h" in changed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -488 lines) Patch
M Source/core/accessibility/AXObjectCache.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/accessibility/AccessibilityNodeObject.cpp View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/accessibility/AccessibilityObject.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/accessibility/AccessibilityObject.cpp View 1 2 1 chunk +2 lines, -10 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/accessibility/AccessibilityTableColumn.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityTableHeaderContainer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSAspectRatioValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSAspectRatioValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSBorderImage.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/CSSFilterValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFace.h View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/css/CSSFontFaceLoadEvent.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/css/CSSFunctionValue.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSLineBoxContainValue.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSMatrix.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSMediaRule.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSOMUtils.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSPageRule.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/css/CSSProperty.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.h View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/css/CSSReflectValue.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSReflectValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSRegionRule.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSRuleList.h View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/css/CSSRuleList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/css/CSSSelector.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/css/CSSStyleSheet.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSSupportsRule.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSTransformValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/DeprecatedStyleBuilder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/DocumentRuleSets.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/ElementRuleCollector.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/FontSize.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/MediaQueryListListener.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/PageRuleCollector.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/RuleSet.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/css/SVGCSSStyleSelector.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/css/StylePropertySerializer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/StyleRuleImport.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 4 chunks +0 lines, -39 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/ChildListMutationScope.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/CustomElementDefinition.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/CustomElementRegistry.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DeviceOrientationController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DeviceOrientationController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +6 lines, -10 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 8 chunks +0 lines, -29 lines 0 comments Download
M Source/core/dom/DocumentEventQueue.h View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/dom/DocumentEventQueue.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ElementRareData.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Event.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/dom/EventDispatcher.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/dom/EventDispatcher.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/EventListenerMap.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/EventRetargeter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/EventTarget.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/EventTarget.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/GestureEvent.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/KeyboardEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/MessagePortChannel.h View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M Source/core/dom/MutationObserver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/MutationRecord.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MutationRecord.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/NamedFlow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NamedFlow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NamedNodesCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 5 chunks +0 lines, -33 lines 0 comments Download
M Source/core/dom/NodeRareData.h View 1 2 1 chunk +5 lines, -9 lines 0 comments Download
M Source/core/dom/NodeRareData.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.cpp View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Range.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/ScriptRunner.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/SpaceSplitString.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/StyledElement.cpp View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/UserActionElementSet.h View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/dom/ViewportArguments.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/VisitedLinkState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/WheelEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ContentDistributor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ContentSelectorQuery.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Timothy Loh
7 years, 6 months ago (2013-06-20 08:40:58 UTC) #1
pdr.
LGTM with nits. https://codereview.chromium.org/17480002/diff/6001/Source/core/accessibility/AccessibilityNodeObject.cpp File Source/core/accessibility/AccessibilityNodeObject.cpp (right): https://codereview.chromium.org/17480002/diff/6001/Source/core/accessibility/AccessibilityNodeObject.cpp#newcode41 Source/core/accessibility/AccessibilityNodeObject.cpp:41: #include <wtf/text/StringBuilder.h> Can you quote these ...
7 years, 6 months ago (2013-06-20 16:08:45 UTC) #2
Timothy Loh
https://codereview.chromium.org/17480002/diff/6001/Source/core/accessibility/AccessibilityNodeObject.cpp File Source/core/accessibility/AccessibilityNodeObject.cpp (right): https://codereview.chromium.org/17480002/diff/6001/Source/core/accessibility/AccessibilityNodeObject.cpp#newcode41 Source/core/accessibility/AccessibilityNodeObject.cpp:41: #include <wtf/text/StringBuilder.h> On 2013/06/20 16:08:45, pdr wrote: > Can ...
7 years, 6 months ago (2013-06-21 04:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/17480002/18001
7 years, 6 months ago (2013-06-21 04:23:44 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 05:36:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 152858

Powered by Google App Engine
This is Rietveld 408576698