delete webkit/support/simple_xxx's

delete webkit/support/simple_xxx's

webkit/support/simple_resource_loader_bridge* primarily after mocks fixed,
which allows the rest of them which depended on the resource loading to
also be deleted.

R=jamesr@chromium.org
BUG=237267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208265

[scottmg, 2013-06-20 04:51:19]

webkit_unit_tests seems to work fine at least...

[jamesr, 2013-06-20 04:58:00]

lgtm

https://codereview.chromium.org/17476002/diff/1/webkit/support/webkit_support.cc
File webkit/support/webkit_support.cc (right):

https://codereview.chromium.org/17476002/diff/1/webkit/support/webkit_support...
webkit/support/webkit_support.cc:770: LOG(ERROR) << "XXX:" << accept;
hmm, NOTREACHED() << accept; ?

[scottmg, 2013-06-20 05:04:32]

turns out they can all go now, woot.

https://codereview.chromium.org/17476002/diff/1/webkit/support/webkit_support.cc
File webkit/support/webkit_support.cc (right):

https://codereview.chromium.org/17476002/diff/1/webkit/support/webkit_support...
webkit/support/webkit_support.cc:770: LOG(ERROR) << "XXX:" << accept;
On 2013/06/20 04:58:00, jamesr wrote:
> hmm, NOTREACHED() << accept; ?

Done.

[commit-bot: I haz the power, 2013-06-24 14:33:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17476002/5001

[commit-bot: I haz the power, 2013-06-24 14:33:23]

Failed to apply patch for webkit/support/test_webkit_platform_support.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file webkit/support/test_webkit_platform_support.h
  Hunk #2 FAILED at 15.
  Hunk #3 succeeded at 47 (offset -1 lines).
  Hunk #4 succeeded at 69 (offset -1 lines).
  Hunk #5 succeeded at 154 (offset -5 lines).
  1 out of 5 hunks FAILED -- saving rejects to file
webkit/support/test_webkit_platform_support.h.rej

Patch:       webkit/support/test_webkit_platform_support.h
Index: webkit/support/test_webkit_platform_support.h
diff --git a/webkit/support/test_webkit_platform_support.h
b/webkit/support/test_webkit_platform_support.h
index
a822a3d238a91e02e75a1d693d84387f99505f37..278e5a556651ca469e725fac0736ede2c48a0336
100644
--- a/webkit/support/test_webkit_platform_support.h
+++ b/webkit/support/test_webkit_platform_support.h
@@ -6,6 +6,7 @@
 #define WEBKIT_SUPPORT_TEST_WEBKIT_PLATFORM_SUPPORT_H_
 
 #include "base/compiler_specific.h"
+#include "base/files/scoped_temp_dir.h"
 #include "third_party/WebKit/public/platform/WebGamepads.h"
 #include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
 #include "third_party/WebKit/public/platform/WebUnitTestSupport.h"
@@ -14,11 +15,6 @@
 #include "webkit/mocks/mock_webhyphenator.h"
 #include "webkit/renderer/compositor_bindings/web_compositor_support_impl.h"
 #include "webkit/support/mock_webclipboard_impl.h"
-#include "webkit/support/simple_appcache_system.h"
-#include "webkit/support/simple_database_system.h"
-#include "webkit/support/simple_dom_storage_system.h"
-#include "webkit/support/simple_file_system.h"
-#include "webkit/support/simple_webcookiejar_impl.h"
 #include "webkit/support/test_shell_webmimeregistry_impl.h"
 #include "webkit/support/weburl_loader_mock_factory.h"
 
@@ -47,23 +43,11 @@ class TestWebKitPlatformSupport :
   virtual WebKit::WebClipboard* clipboard();
   virtual WebKit::WebFileUtilities* fileUtilities();
   virtual WebKit::WebSandboxSupport* sandboxSupport();
-  virtual WebKit::WebCookieJar* cookieJar();
   virtual WebKit::WebBlobRegistry* blobRegistry();
-  virtual WebKit::WebFileSystem* fileSystem();
   virtual WebKit::WebHyphenator* hyphenator();
   virtual WebKit::WebIDBFactory* idbFactory();
 
   virtual bool sandboxEnabled();
-  virtual WebKit::Platform::FileHandle databaseOpenFile(
-      const WebKit::WebString& vfs_file_name, int desired_flags);
-  virtual int databaseDeleteFile(const WebKit::WebString& vfs_file_name,
-                                 bool sync_dir);
-  virtual long databaseGetFileAttributes(
-      const WebKit::WebString& vfs_file_name);
-  virtual long long databaseGetFileSize(
-      const WebKit::WebString& vfs_file_name);
-  virtual long long databaseGetSpaceAvailableForOrigin(
-      const WebKit::WebString& origin_identifier);
   virtual unsigned long long visitedLinkHash(const char* canonicalURL,
                                              size_t length);
   virtual bool isLinkVisited(unsigned long long linkHash);
@@ -81,8 +65,6 @@ class TestWebKitPlatformSupport :
       const WebKit::WebString& value1,
       const WebKit::WebString& value2);
   virtual WebKit::WebString defaultLocale();
-  virtual WebKit::WebStorageNamespace* createLocalStorageNamespace(
-      const WebKit::WebString& path, unsigned quota);
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
   void SetThemeEngine(WebKit::WebThemeEngine* engine);
@@ -172,12 +154,7 @@ class TestWebKitPlatformSupport :
   MockWebClipboardImpl mock_clipboard_;
   webkit_glue::WebFileUtilitiesImpl file_utilities_;
   base::ScopedTempDir appcache_dir_;
-  SimpleAppCacheSystem appcache_system_;
-  SimpleDatabaseSystem database_system_;
-  SimpleDomStorageSystem dom_storage_system_;
-  SimpleWebCookieJarImpl cookie_jar_;
   scoped_refptr<TestShellWebBlobRegistryImpl> blob_registry_;
-  SimpleFileSystem file_system_;
   base::ScopedTempDir file_system_root_;
   webkit_glue::MockWebHyphenator hyphenator_;
   WebURLLoaderMockFactory url_loader_factory_;

[commit-bot: I haz the power, 2013-06-24 17:01:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17476002/16001

[commit-bot: I haz the power, 2013-06-24 17:21:54]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-24 17:25:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17476002/28002

[commit-bot: I haz the power, 2013-06-24 17:53:18]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-24 18:02:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17476002/26002

[commit-bot: I haz the power, 2013-06-24 21:47:12]

Change committed as 208265