Issue 17463006: Fix a history bug where a reload is given a standard load's history entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17463006: Fix a history bug where a reload is given a standard load's history entry. (Closed)

Created:
7 years, 6 months ago by Nate Chapin

Modified:
7 years, 6 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix a history bug where a reload is given a standard load's history entry. If a resource load is started after the load event and a reload is triggered before that resource load finishes, the load will be cancelled and in doing so will incorrectly revert the new load's load type to FrameLoadTypeStandard. This was regressed in r148684 BUG=241581 TEST=http/tests/history/reload-during-load-after-load-event.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152781

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -8 lines)			Patch
A	LayoutTests/http/tests/history/reload-during-load-after-load-event.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/loader/FrameLoader.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View	5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/17463006/1

7 years, 6 months ago (2013-06-20 01:49:09 UTC) #3

Message was sent while issue was closed.

Change committed as 152781

Expand Messages | Collapse Messages