Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: base/metrics/statistics_recorder_unittest.cc

Issue 17451016: [UMA] Remove redundant bucket_count variable from base::Histogram. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename variables to be clearer Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/sparse_histogram.cc ('k') | net/disk_cache/stats_histogram.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/statistics_recorder_unittest.cc
diff --git a/base/metrics/statistics_recorder_unittest.cc b/base/metrics/statistics_recorder_unittest.cc
index ea91e8e8e9b601e90b8658d429e789b26ffccefb..22504ddfdda7e64c1b7bb21942d5839f8c911397 100644
--- a/base/metrics/statistics_recorder_unittest.cc
+++ b/base/metrics/statistics_recorder_unittest.cc
@@ -36,7 +36,11 @@ class StatisticsRecorderTest : public testing::Test {
HistogramBase::Sample min,
HistogramBase::Sample max,
size_t bucket_count) {
- return new Histogram(name, min, max, bucket_count, NULL);
+ BucketRanges* ranges = new BucketRanges(bucket_count + 1);
+ Histogram::InitializeBucketRanges(min, max, ranges);
+ const BucketRanges* registered_ranges =
+ StatisticsRecorder::RegisterOrDeleteDuplicateRanges(ranges);
+ return new Histogram(name, min, max, registered_ranges);
}
void DeleteHistogram(HistogramBase* histogram) {
« no previous file with comments | « base/metrics/sparse_histogram.cc ('k') | net/disk_cache/stats_histogram.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698