Change WGC3DInProcessCBImpl factories to return a base class pointer.

Change WGC3DInProcessCBImpl factories to return a base class pointer.

TBR=sky@chromium.org for ui/aura/bench/bench_main.cc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207782

[no sievers, 2013-06-19 23:04:56]

ptal

[jamesr, 2013-06-19 23:07:16]

nice! lgtm, although we could use slightly more smarter pointers if you're
inclined

https://codereview.chromium.org/17447007/diff/1/webkit/common/gpu/webgraphics...
File webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
(right):

https://codereview.chromium.org/17447007/diff/1/webkit/common/gpu/webgraphics...
webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h:50:
static WebKit::WebGraphicsContext3D*
not your fault, but this would be better if it returned a scoped_ptr<> instead
of a raw pointer

[no sievers, 2013-06-20 00:43:47]

https://codereview.chromium.org/17447007/diff/1/webkit/common/gpu/webgraphics...
File webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h
(right):

https://codereview.chromium.org/17447007/diff/1/webkit/common/gpu/webgraphics...
webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h:50:
static WebKit::WebGraphicsContext3D*
On 2013/06/19 23:07:16, jamesr wrote:
> not your fault, but this would be better if it returned a scoped_ptr<> instead
> of a raw pointer

Done.

[commit-bot: I haz the power, 2013-06-20 01:56:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/17447007/8001

[commit-bot: I haz the power, 2013-06-20 03:22:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[no sievers, 2013-06-20 17:10:31]

+piman for ui/compositor/compositor.h/.cc - had to adjust the call sites there
for the WGC3DIPCB factory methods returning a scoped_ptr

[piman, 2013-06-20 17:12:36]

lgtm

[danakj, 2013-06-20 17:13:03]

Thanks for doing this!

[no sievers, 2013-06-20 19:06:41]

@piman: Sorry I missed some covariant virtual functions that I had to make more
explicit with scoped_ptr. Could you take a quick look at
content/browser/renderer_host/image_transport_factory.cc?

[piman, 2013-06-20 19:41:06]

lgtm

[commit-bot: I haz the power, 2013-06-20 22:26:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/17447007/34001

[commit-bot: I haz the power, 2013-06-20 22:27:00]

Failed to apply patch for cc/test/layer_tree_pixel_test.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/test/layer_tree_pixel_test.cc
  Hunk #1 FAILED at 42.
  Hunk #2 succeeded at 189 (offset 14 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
cc/test/layer_tree_pixel_test.cc.rej

Patch:       cc/test/layer_tree_pixel_test.cc
Index: cc/test/layer_tree_pixel_test.cc
diff --git a/cc/test/layer_tree_pixel_test.cc b/cc/test/layer_tree_pixel_test.cc
index
3d757cab3d46b98e3beb8ab50de2806f3e047842..83c0bfc15b1445d4714c8996277c128dc5e989df
100644
--- a/cc/test/layer_tree_pixel_test.cc
+++ b/cc/test/layer_tree_pixel_test.cc
@@ -42,7 +42,7 @@ scoped_ptr<OutputSurface>
LayerTreePixelTest::CreateOutputSurface() {
 
     using WebKit::WebGraphicsContext3D;
     using webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl;
-    scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl> context3d(
+    scoped_ptr<WebKit::WebGraphicsContext3D> context3d(
         WebGraphicsContext3DInProcessCommandBufferImpl::CreateOffscreenContext(
             WebGraphicsContext3D::Attributes()));
     output_surface = make_scoped_ptr(
@@ -175,7 +175,7 @@ scoped_ptr<SkBitmap>
LayerTreePixelTest::CopyTextureMailboxToBitmap(
     return scoped_ptr<SkBitmap>();
 
   using webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl;
-  scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl> context3d(
+  scoped_ptr<WebKit::WebGraphicsContext3D> context3d(
       WebGraphicsContext3DInProcessCommandBufferImpl::CreateOffscreenContext(
           WebKit::WebGraphicsContext3D::Attributes()));

[commit-bot: I haz the power, 2013-06-20 22:35:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/17447007/44001

[commit-bot: I haz the power, 2013-06-20 23:13:35]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-20 23:29:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/17447007/63001

[commit-bot: I haz the power, 2013-06-20 23:41:42]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-20 23:56:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/17447007/63001

[commit-bot: I haz the power, 2013-06-21 00:08:38]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-21 00:27:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/17447007/63001

[commit-bot: I haz the power, 2013-06-21 10:03:39]

Change committed as 207782