Issue 17426002: Add WebFrameClient to RenderFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17426002: Add WebFrameClient to RenderFrame. (Closed)

Created:
7 years, 6 months ago by nasko

Modified:
7 years, 6 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add WebFrameClient to RenderFrame. This is the same code as the one in https://codereview.chromium.org/16223006/, except it doesn't register the RenderFrameImpl instance as the main frame, since that breaks Blink layout tests. Once those tests are fixed, I'll switch the main frame to be RenderFrame. BUG=245126 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207133

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+565 lines, -4 lines)			Patch
	M	content/renderer/render_frame_impl.h	View		3 chunks	+184 lines, -2 lines	0 comments	Download
	M	content/renderer/render_frame_impl.cc	View		2 chunks	+381 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

nasko

Charlie, This is the same CL as https://codereview.chromium.org/16223006/ without changing the main frame initialization. Please ...

7 years, 6 months ago (2013-06-18 19:10:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/17426002/1

7 years, 6 months ago (2013-06-18 19:54:39 UTC) #3

Message was sent while issue was closed.

Change committed as 207133