Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 17397006: Fix the problem that some stacked panels might not be brought to the top when a collapsed panel is … (Closed)

Created:
7 years, 6 months ago by jianli
Modified:
7 years, 6 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, jennb, jianli, dcheng
Visibility:
Public.

Description

Fix the problem that some stacked panels might not be brought to the top when a collapsed panel is clicked on Linux BUG=251829 TEST=Manual test by creating stacked panels and collapsing and expanding some of them Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207850

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/browser/ui/gtk/panels/panel_gtk.cc View 1 2 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jianli
7 years, 6 months ago (2013-06-19 18:28:45 UTC) #1
Dmitry Titov
https://codereview.chromium.org/17397006/diff/1/chrome/browser/ui/gtk/panels/panel_gtk.cc File chrome/browser/ui/gtk/panels/panel_gtk.cc (right): https://codereview.chromium.org/17397006/diff/1/chrome/browser/ui/gtk/panels/panel_gtk.cc#newcode889 chrome/browser/ui/gtk/panels/panel_gtk.cc:889: // seems not to be too bad. Since we ...
7 years, 6 months ago (2013-06-20 00:57:23 UTC) #2
jianli
Changed to keep the minimized panel to accept no focus, as discussed.
7 years, 6 months ago (2013-06-20 20:17:18 UTC) #3
Dmitry Titov
I don't really like this, but lgtm as it makes the symptoms much less problematic...
7 years, 6 months ago (2013-06-21 02:15:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/17397006/12001
7 years, 6 months ago (2013-06-21 03:04:06 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 16:20:34 UTC) #6
Message was sent while issue was closed.
Change committed as 207850

Powered by Google App Engine
This is Rietveld 408576698