Fix the problem that some stacked panels might not be brought to the top when a collapsed panel is …

chrome/browser/ui/gtk/panels/panel_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/panels/panel_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
@@ skipping 177 matching lines @@
 gfx::Size& GetFrameSize() {
   CR_DEFINE_STATIC_LOCAL(gfx::Size, frame_size, ());
   return frame_size;
 }
 
 void SetFrameSize(const gfx::Size& new_size) {
   gfx::Size& frame_size = GetFrameSize();
   frame_size.SetSize(new_size.width(), new_size.height());
 }
 
-}
+}  // namespace
 
 // static
 NativePanel* Panel::CreateNativePanel(Panel* panel,
                                       const gfx::Rect& bounds,
                                       bool always_on_top) {
   PanelGtk* panel_gtk = new PanelGtk(panel, bounds, always_on_top);
   panel_gtk->Init();
   return panel_gtk;
 }
 
@@ skipping 392 matching lines @@
                    FALSE, FALSE, 0);
 }
 
 gboolean PanelGtk::OnTitlebarButtonPressEvent(
     GtkWidget* widget, GdkEventButton* event) {
   if (event->button != 1)
     return TRUE;
   if (event->type != GDK_BUTTON_PRESS)
     return TRUE;
 
-  gdk_window_raise(gtk_widget_get_window(GTK_WIDGET(window_)));
+  // If the panel is in a stack, bring all other panels in the stack to the
+  // top.
+  StackedPanelCollection* stack = panel_->stack();
+  if (stack) {
+    for (StackedPanelCollection::Panels::const_iterator iter =
+             stack->panels().begin();
+         iter != stack->panels().end(); ++iter) {
+      Panel* panel = *iter;
+      GtkWindow* gtk_window = panel->GetNativeWindow();
+      // If a panel is collapsed, we make it not to take focus. For such window,
+      // it cannot be brought to the top by calling gdk_window_raise. To work
+      // around this issue, we make it always-on-top first and then put it back
+      // to normal. Note that this trick has been done for all panels in the
+      // stack, regardless of whether it is collapsed or not.
+      // There is one side-effect to this approach: if the panel being pressed
+      // on is collapsed, clicking on the client area of the last active
+      // window will not raise it above these panels.
+      gtk_window_set_keep_above(gtk_window, true);
+      gtk_window_set_keep_above(gtk_window, false);
+    }
+  } else {
+    gdk_window_raise(gtk_widget_get_window(GTK_WIDGET(window_)));
+  }
+
   EnsureDragHelperCreated();
   drag_helper_->InitialTitlebarMousePress(event, titlebar_->widget());
   return TRUE;
 }
 
 gboolean PanelGtk::OnTitlebarButtonReleaseEvent(
     GtkWidget* widget, GdkEventButton* event) {
   if (event->button != 1)
     return TRUE;
 
@@ skipping 561 matching lines @@
     default:
       NOTREACHED();
       return false;
   }
   return gtk_widget_get_visible(button->widget());
 }
 
 panel::CornerStyle GtkNativePanelTesting::GetWindowCornerStyle() const {
   return panel_gtk_->corner_style_;
 }