Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
index c6bb14a99a33536889d112c09bfbc3deb2a6b653..245511bbddf03c2cbe86d2578b6b7f9a2e390705 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
@@ -8,6 +8,7 @@ import android.app.Activity;
import android.content.Context;
import android.os.Environment;
+import org.chromium.base.Callback;
import org.chromium.base.Log;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
@@ -223,8 +224,20 @@ public class OfflinePageUtils {
@Override
public void onAction(Object actionData) {
RecordUserAction.record("OfflinePages.SaveStatusSnackbar.FreeUpSpaceButtonClicked");
- OfflinePageStorageSpacePolicy policy =
- new OfflinePageStorageSpacePolicy(offlinePageBridge);
+ Callback<OfflinePageStorageSpacePolicy> callback =
+ getStorageSpacePolicyCallback(offlinePageBridge, snackbarManager, activity);
+
+ OfflinePageStorageSpacePolicy.create(offlinePageBridge, callback);
+ }
+ };
+ }
+
+ private static Callback<OfflinePageStorageSpacePolicy> getStorageSpacePolicyCallback(
+ final OfflinePageBridge offlinePageBridge, final SnackbarManager snackbarManager,
+ final Activity activity) {
+ return new Callback<OfflinePageStorageSpacePolicy>() {
+ @Override
+ public void onResult(OfflinePageStorageSpacePolicy policy) {
if (policy.hasPagesToCleanUp()) {
OfflinePageFreeUpSpaceCallback callback = new OfflinePageFreeUpSpaceCallback() {
@Override

Powered by Google App Engine
This is Rietveld 408576698