Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1739503002: Makes the OfflinePageBridge.getAllPages method asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix some comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.offlinepages; 5 package org.chromium.chrome.browser.offlinepages;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.Context; 8 import android.content.Context;
9 import android.os.Environment; 9 import android.os.Environment;
10 10
11 import org.chromium.base.Callback;
11 import org.chromium.base.Log; 12 import org.chromium.base.Log;
12 import org.chromium.base.metrics.RecordUserAction; 13 import org.chromium.base.metrics.RecordUserAction;
13 import org.chromium.chrome.R; 14 import org.chromium.chrome.R;
14 import org.chromium.chrome.browser.ChromeActivity; 15 import org.chromium.chrome.browser.ChromeActivity;
15 import org.chromium.chrome.browser.snackbar.Snackbar; 16 import org.chromium.chrome.browser.snackbar.Snackbar;
16 import org.chromium.chrome.browser.snackbar.SnackbarManager; 17 import org.chromium.chrome.browser.snackbar.SnackbarManager;
17 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController; 18 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
18 import org.chromium.chrome.browser.tab.Tab; 19 import org.chromium.chrome.browser.tab.Tab;
19 import org.chromium.chrome.browser.tabmodel.TabModelSelector; 20 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
20 import org.chromium.components.offlinepages.FeatureMode; 21 import org.chromium.components.offlinepages.FeatureMode;
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 @Override 217 @Override
217 public void onDismissNoAction(Object actionData) { 218 public void onDismissNoAction(Object actionData) {
218 // This method will be called only if the snackbar is dismissed by timeout. 219 // This method will be called only if the snackbar is dismissed by timeout.
219 RecordUserAction.record( 220 RecordUserAction.record(
220 "OfflinePages.SaveStatusSnackbar.FreeUpSpaceButtonNotCli cked"); 221 "OfflinePages.SaveStatusSnackbar.FreeUpSpaceButtonNotCli cked");
221 } 222 }
222 223
223 @Override 224 @Override
224 public void onAction(Object actionData) { 225 public void onAction(Object actionData) {
225 RecordUserAction.record("OfflinePages.SaveStatusSnackbar.FreeUpS paceButtonClicked"); 226 RecordUserAction.record("OfflinePages.SaveStatusSnackbar.FreeUpS paceButtonClicked");
226 OfflinePageStorageSpacePolicy policy = 227 Callback<OfflinePageStorageSpacePolicy> callback =
227 new OfflinePageStorageSpacePolicy(offlinePageBridge); 228 getStorageSpacePolicyCallback(offlinePageBridge, snackba rManager, activity);
229
230 OfflinePageStorageSpacePolicy.create(offlinePageBridge, callback );
231 }
232 };
233 }
234
235 private static Callback<OfflinePageStorageSpacePolicy> getStorageSpacePolicy Callback(
236 final OfflinePageBridge offlinePageBridge, final SnackbarManager sna ckbarManager,
237 final Activity activity) {
238 return new Callback<OfflinePageStorageSpacePolicy>() {
239 @Override
240 public void onResult(OfflinePageStorageSpacePolicy policy) {
228 if (policy.hasPagesToCleanUp()) { 241 if (policy.hasPagesToCleanUp()) {
229 OfflinePageFreeUpSpaceCallback callback = new OfflinePageFre eUpSpaceCallback() { 242 OfflinePageFreeUpSpaceCallback callback = new OfflinePageFre eUpSpaceCallback() {
230 @Override 243 @Override
231 public void onFreeUpSpaceDone() { 244 public void onFreeUpSpaceDone() {
232 snackbarManager.showSnackbar( 245 snackbarManager.showSnackbar(
233 OfflinePageFreeUpSpaceDialog.createStorageCl earedSnackbar( 246 OfflinePageFreeUpSpaceDialog.createStorageCl earedSnackbar(
234 activity)); 247 activity));
235 } 248 }
236 @Override 249 @Override
237 public void onFreeUpSpaceCancelled() {} 250 public void onFreeUpSpaceCancelled() {}
(...skipping 30 matching lines...) Expand all
268 foundTab.loadUrl(params); 281 foundTab.loadUrl(params);
269 } 282 }
270 283
271 @Override 284 @Override
272 public void onDismissNoAction(Object actionData) { 285 public void onDismissNoAction(Object actionData) {
273 RecordUserAction.record("OfflinePages.ReloadButtonNotClicked"); 286 RecordUserAction.record("OfflinePages.ReloadButtonNotClicked");
274 } 287 }
275 }; 288 };
276 } 289 }
277 } 290 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698