drive: Introduce chrome/browser/google_apis/drive_common_callbacks.h

drive: Introduce chrome/browser/google_apis/drive_common_callbacks.h

To cut dependency from c/b/google_apis to c/b/drive.

BUG=244325
TEST=none
R=kinaba@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207171

[tfarina, 2013-06-19 01:26:12]

https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_common_callbacks.h (right):

https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_common_callbacks.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
supernit: no (c) and just 2013.

[satorux1, 2013-06-19 01:27:47]

https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_common_callbacks.h (right):

https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_common_callbacks.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2013/06/19 01:26:12, tfarina wrote:
> supernit: no (c) and just 2013.

Thanks! Fixed.

[tfarina, 2013-06-19 01:27:53]

https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_se...
File chrome/browser/drive/drive_service_interface.h (right):

https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_se...
chrome/browser/drive/drive_service_interface.h:15: namespace google_apis {
do you plan to update this namespace to just drive in future?

https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_se...
chrome/browser/drive/drive_service_interface.h:18: class DriveServiceObserver {
this could get this own header file, but I guess it's here for convenience,
since it's tied to DriveServiceInterface. At least this isn't a nested class :)

[satorux1, 2013-06-19 01:30:10]

https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_se...
File chrome/browser/drive/drive_service_interface.h (right):

https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_se...
chrome/browser/drive/drive_service_interface.h:15: namespace google_apis {
On 2013/06/19 01:27:53, tfarina wrote:
> do you plan to update this namespace to just drive in future?

yes.

https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_se...
chrome/browser/drive/drive_service_interface.h:18: class DriveServiceObserver {
On 2013/06/19 01:27:53, tfarina wrote:
> this could get this own header file, but I guess it's here for convenience,
> since it's tied to DriveServiceInterface. At least this isn't a nested class
:)

yes. we removed nested classes from drive related code.

[kinaba, 2013-06-19 02:04:11]

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
File chrome/browser/google_apis/drive_api_requests.h (right):

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
chrome/browser/google_apis/drive_api_requests.h:11: #include
"chrome/browser/drive/drive_service_interface.h"
Do you still need this #include?

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_requests.h (right):

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_requests.h:11: #include
"chrome/browser/drive/drive_service_interface.h"
ditto

[satorux1, 2013-06-19 03:24:09]

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
File chrome/browser/google_apis/drive_api_requests.h (right):

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
chrome/browser/google_apis/drive_api_requests.h:11: #include
"chrome/browser/drive/drive_service_interface.h"
On 2013/06/19 02:04:11, kinaba wrote:
> Do you still need this #include?

Done.

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_requests.h (right):

https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_requests.h:11: #include
"chrome/browser/drive/drive_service_interface.h"
On 2013/06/19 02:04:11, kinaba wrote:
> ditto

Done. good catch!

[kinaba, 2013-06-19 03:46:08]

lgtm

[satorux1, 2013-06-19 04:03:56]

Committed patchset #4 manually as r207171 (presubmit successful).