Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 17395010: drive: Introduce chrome/browser/google_apis/drive_common_callbacks.h (Closed)

Created:
7 years, 6 months ago by satorux1
Modified:
7 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

drive: Introduce chrome/browser/google_apis/drive_common_callbacks.h To cut dependency from c/b/google_apis to c/b/drive. BUG=244325 TEST=none R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207171

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix copyright #

Total comments: 4

Patch Set 3 : address comments #

Patch Set 4 : fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -48 lines) Patch
M chrome/browser/drive/drive_service_interface.h View 2 chunks +1 line, -42 lines 0 comments Download
M chrome/browser/google_apis/DEPS View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/drive_api_requests.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/google_apis/drive_common_callbacks.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_requests.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
satorux1
7 years, 6 months ago (2013-06-19 01:24:45 UTC) #1
tfarina
https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/drive_common_callbacks.h File chrome/browser/google_apis/drive_common_callbacks.h (right): https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/drive_common_callbacks.h#newcode1 chrome/browser/google_apis/drive_common_callbacks.h:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 6 months ago (2013-06-19 01:26:12 UTC) #2
satorux1
https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/drive_common_callbacks.h File chrome/browser/google_apis/drive_common_callbacks.h (right): https://codereview.chromium.org/17395010/diff/1/chrome/browser/google_apis/drive_common_callbacks.h#newcode1 chrome/browser/google_apis/drive_common_callbacks.h:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 6 months ago (2013-06-19 01:27:47 UTC) #3
tfarina
https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_service_interface.h File chrome/browser/drive/drive_service_interface.h (right): https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_service_interface.h#newcode15 chrome/browser/drive/drive_service_interface.h:15: namespace google_apis { do you plan to update this ...
7 years, 6 months ago (2013-06-19 01:27:53 UTC) #4
satorux1
https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_service_interface.h File chrome/browser/drive/drive_service_interface.h (right): https://codereview.chromium.org/17395010/diff/1/chrome/browser/drive/drive_service_interface.h#newcode15 chrome/browser/drive/drive_service_interface.h:15: namespace google_apis { On 2013/06/19 01:27:53, tfarina wrote: > ...
7 years, 6 months ago (2013-06-19 01:30:10 UTC) #5
kinaba
https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis/drive_api_requests.h File chrome/browser/google_apis/drive_api_requests.h (right): https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis/drive_api_requests.h#newcode11 chrome/browser/google_apis/drive_api_requests.h:11: #include "chrome/browser/drive/drive_service_interface.h" Do you still need this #include? https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis/gdata_wapi_requests.h ...
7 years, 6 months ago (2013-06-19 02:04:11 UTC) #6
satorux1
https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis/drive_api_requests.h File chrome/browser/google_apis/drive_api_requests.h (right): https://codereview.chromium.org/17395010/diff/5001/chrome/browser/google_apis/drive_api_requests.h#newcode11 chrome/browser/google_apis/drive_api_requests.h:11: #include "chrome/browser/drive/drive_service_interface.h" On 2013/06/19 02:04:11, kinaba wrote: > Do ...
7 years, 6 months ago (2013-06-19 03:24:09 UTC) #7
kinaba
lgtm
7 years, 6 months ago (2013-06-19 03:46:08 UTC) #8
satorux1
7 years, 6 months ago (2013-06-19 04:03:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r207171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698