Implement 'invalid' AutocompleteErrorEvent#reason

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index 2748ec382cefbe4bf93f8dcfbe99b72b051db508..dabf0158e5da478c2d8f579579160baa32f7c945 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -9,6 +9,7 @@
 #include <vector>
 
 #include "base/callback.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
@@ -287,6 +288,12 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
   virtual void OnWalletSigninError();
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest, AutocompleteEvent);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           AutocompleteErrorEventReasonInvalid);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           AutocompleteErrorEventReasonCancel);

[Ilya Sherman, 2013/06/19 23:56:14]

Why do we need to friend the tests?  IMO it's much better to expose subsets of
the private functionality to tests, rather than letting tests muck with
internals arbitrarily.

[Dan Beam, 2013/06/20 00:26:57]

AutofillDialogControllerImpl::view() (not TestAutofillDialogController)

[Ilya Sherman, 2013/06/20 01:11:27]

I'd much rather expose a GetTestableView() method publicly than add friend
tests.

[Dan Beam, 2013/06/20 01:47:09]

Done.

+
   // Whether or not the current request wants credit info back.
   bool RequestingCreditCardInfo() const;